Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputStream can report closed == true before onClosed is called. #3610

Closed
whesse opened this issue Jun 13, 2012 · 2 comments
Closed

InputStream can report closed == true before onClosed is called. #3610

whesse opened this issue Jun 13, 2012 · 2 comments
Assignees
@whesse
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-io
Milestone
M1

Comments

@whesse
Copy link
Contributor

whesse commented Jun 13, 2012

The new implementation of _FileInputStream can return true from bool get closed() before the closed handler has been called. This is wrong and should be changed, and tested (line 229 of file_test.dart is a place where closed is true, and should be false).
@whesse
Copy link
Contributor Author

whesse commented Jun 18, 2012

Fixed in r8649

Added Fixed label.

@kevmoo
Copy link
Member

kevmoo commented May 14, 2014

Removed Area-IO label.
Added Area-Library, Library-IO labels.

@whesse whesse added Type-Defect area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-io labels May 14, 2014
@whesse whesse self-assigned this May 14, 2014
@whesse whesse added this to the M1 milestone May 14, 2014
copybara-service bot pushed a commit that referenced this issue Oct 18, 2022
@sigurdm
Bump pub to 817e61d9eb174f77dfd2cb1d1de45826f66ac6bf
250db68 
Changes:
```
> git log --format="%C(auto) %h %s" 28a2503..817e61d
 https://dart.googlesource.com/pub.git/+/817e61d9 Fix publishing (#3610)
 https://dart.googlesource.com/pub.git/+/97f638d0 PubToplevel.directory is never null. (#3587)
 https://dart.googlesource.com/pub.git/+/a3ee2099 Make binstubs offset invariant (#3586)
 https://dart.googlesource.com/pub.git/+/67e44b4b Make >=2.12 <3.0.0 compatible with dart 3 (#3572)
 https://dart.googlesource.com/pub.git/+/c287c110 Warn on `pub publish` if `dart analyze` has messages (#3568)
 https://dart.googlesource.com/pub.git/+/29d7d868 Cleaner pubspec.lock parsing (#3487)

```

Diff: https://dart.googlesource.com/pub.git/+/28a2503d7f4806e6854e3ed0d783f065abfd1b5f~..817e61d9eb174f77dfd2cb1d1de45826f66ac6bf/
Change-Id: I203963479a2bb78db80d8e645066a227febeef46
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264680
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whesse whesse

Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-io
Projects
None yet
Milestone
M1
Development

No branches or pull requests
2 participants
@kevmoo @whesse