Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all debugging functionality out from unoptimized code to the interpreter #36427

Closed
a-siva opened this issue Apr 2, 2019 · 1 comment
Closed

Move all debugging functionality out from unoptimized code to the interpreter #36427

a-siva opened this issue Apr 2, 2019 · 1 comment
Assignees
@crelier
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. customer-fuchsia

Comments

@a-siva
Copy link
Contributor

a-siva commented Apr 2, 2019

Move all debugging functionality out from unoptimized code to the interpreter so the unoptimized code does not have to make any of the runtime debugger check calls.
@a-siva a-siva added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. customer-fuchsia labels Apr 2, 2019
@a-siva a-siva mentioned this issue Apr 2, 2019
Closed
11 tasks
dart-bot pushed a commit that referenced this issue May 22, 2019
@alexmarkov
[vm/bytecode] Add starting and ending source positions for closures
ec4d48e 
Issue: #36427
Change-Id: Ib2f55504f9238036a9700f1e2672b4641536ab7c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103480
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
dart-bot pushed a commit that referenced this issue Jun 28, 2019
@alexmarkov
[vm/bytecode] Add yield point markers to source positions
f91089f 
Issue: #36427
Change-Id: I384161fd27b977e05796666c9a1a1e336d4d6440
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107572
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
dart-bot pushed a commit that referenced this issue Jul 26, 2019
@alexmarkov
[vm/bytecode] Generate bytecode for expression evaluation
16f7076 
Issue: #36427

Change-Id: I0a07bd8ff1be357d2962e6745c8ef1e500d45477
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109984
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
@crelier
Copy link
Contributor

crelier commented Sep 16, 2019

It was decided to support simultaneous debugging of interpreted and compiled code (compiled from bytecode or from AST). We can consider this issue as closed, since it is now possible to debug compiled bytecode in the same way as unoptimized code. There are still a few service tests failing when using the mixed mode interpreted/compiled, but they will be addressed as we deploy this mode.

@crelier crelier closed this as completed Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crelier crelier

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. customer-fuchsia
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crelier @a-siva