Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement lazy evaluations of constants instead of eagerly reading the constant table and evaluating all constants while loading the kernel file #36584

Closed
a-siva opened this issue Apr 11, 2019 · 3 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. customer-fuchsia P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone

Comments

@a-siva
Copy link
Contributor

a-siva commented Apr 11, 2019

With CFE now evaluating constant expressions when constant_update_2018 is used the kernel file has a constant table and the VM eagerly reads the constant table and evaluates all the constants in it while loading the kernel file. This eager reading will not work when we load multiple kernel files with some kernel files having forward references.

Instead constants should be read and evaluated lazily when they are needed.

@a-siva a-siva added the area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. label Apr 11, 2019
@aartbik
Copy link
Contributor

aartbik commented Apr 11, 2019

A WIP CL can be found at:

https://dart-review.googlesource.com/c/sdk/+/99088

@a-siva a-siva added this to the D24 Release milestone May 7, 2019
@aadilmaan aadilmaan added the P1 A high priority bug; for example, a single project is unusable or has many test failures label May 22, 2019
@dgrove dgrove modified the milestones: D24 Release, D25 Release Jun 5, 2019
@dgrove
Copy link
Contributor

dgrove commented Jun 5, 2019

Not required for D24

@aartbik
Copy link
Contributor

aartbik commented Jun 21, 2019

The lazy constant reader has been submitted, so I am closing this bug. All follow-up items are tracked in the related bug #36220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. customer-fuchsia P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

No branches or pull requests

4 participants