Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip tests at next co19 roll #36595

Closed
askeksa-google opened this issue Apr 12, 2019 · 1 comment
Closed

Unskip tests at next co19 roll #36595

askeksa-google opened this issue Apr 12, 2019 · 1 comment
Assignees
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).

Comments

@askeksa-google
Copy link

When dart-lang/co19@525b59a is rolled, the tests Language/Expressions/Constants/literal_string_t04 and Language/Expressions/Constants/no_other_constant_expressions_t17 should be unskipped.

@askeksa-google askeksa-google added the area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). label Apr 12, 2019
dart-bot pushed a commit that referenced this issue Apr 12, 2019
Fixes #32517
Fixes #34189
Fixes #34192
Fixes #34205

Unskipping the skipped tests is tracked by
#36433 and
#36595.

Expectation files for front-end tests will need to be updated to make
front-end builders green. They are part of unapprovable suites.

Change-Id: I311f449af6feff5bf40740227a95aa06e0a9d84f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99169
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
@askeksa-google
Copy link
Author

The updated tests are rolled, and they are no longer skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).
Projects
None yet
Development

No branches or pull requests

2 participants