Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release x64 build failure #36774

Closed
aam opened this issue Apr 26, 2019 · 3 comments
Closed

release x64 build failure #36774

aam opened this issue Apr 26, 2019 · 3 comments
Assignees
@aartbik
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@aam
Copy link
Contributor

aam commented Apr 26, 2019 

$ tools/build.py -m release
...
ninja -C xcodebuild/ReleaseX64 all
ninja: Entering directory `xcodebuild/ReleaseX64'
[26/4606] CXX obj/runtime/lib/libdart_lib_libfuzzer.linked_hash_map.o
FAILED: obj/runtime/lib/libdart_lib_libfuzzer.linked_hash_map.o 
../../buildtools/mac-x64/clang/bin/clang++ -MMD -MF obj/runtime/lib/libdart_lib_libfuzzer.linked_hash_map.o.d -DTOOLCHAIN_VERSION=G7eOyuZijW5lcBsr93UxD6Z1h_83iJ5K8wPvINDDAKkC -D_FORTIFY_SOURCE=2 -DNDEBUG -DTARGET_ARCH_X64 -DNDEBUG -DTARGET_OS_MACOS -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION -I../../runtime -I../.. -Igen -I../../runtime/include -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk -mmacosx-version-min=10.8  -fno-exceptions -arch x86_64 -fcolor-diagnostics -Wall -Wextra -Werror -Wendif-labels -Wno-missing-field-initializers -Wno-unused-parameter -Wno-tautological-constant-compare -Wpartial-availability -fdebug-prefix-map=/Users/keertip/src/dart-sdk2/sdk=../.. -no-canonical-prefixes -stdlib=libc++ -Wheader-hygiene -Wstring-conversion -O3 -fno-ident -fdata-sections -ffunction-sections -g3 -ggdb3 -Werror -Wall -Wextra -Wno-unused-parameter -Wno-unused-private-field -Wnon-virtual-dtor -Wvla -Wno-conversion-null -Woverloaded-virtual -Wno-comments -g3 -ggdb3 -fno-rtti -fno-exceptions -Wimplicit-fallthrough -O3 -fsanitize=address,fuzzer-no-link -fvisibility-inlines-hidden -fno-omit-frame-pointer -std=c++11 -fno-rtti -fno-exceptions -c ../../runtime/lib/linked_hash_map.cc -o obj/runtime/lib/libdart_lib_libfuzzer.linked_hash_map.o
In file included from <built-in>:387:
<command line>:2:9: error: '_FORTIFY_SOURCE' macro redefined [-Werror,-Wmacro-redefined]
#define _FORTIFY_SOURCE 2
        ^
@aartbik aartbik added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Apr 26, 2019
@aartbik
Copy link
Contributor

aartbik commented Apr 26, 2019 •
edited
Loading

The dart_libfuzzer can only be built in combination with asan (either export DART_USE_ASAN=1 or run ./tools/gn.py --mode=debug --asan). I will add a better assert on this.

In that context, I verified it builds for the following:

./tools/build.py -m all -a x64,simarm64,arm64 dart_libfuzzer

@aam
Copy link
Contributor Author

aam commented Apr 26, 2019

cc @keertip

@aartbik
Copy link
Contributor

aartbik commented Apr 26, 2019

Talked with @zanderso : an if around the build target is better than assert, and even avoids breaking "build all".

dart-bot pushed a commit that referenced this issue Apr 26, 2019
@aartbik
[dart/fuzzer] no target on unsupported build targets
ec15148 
Rationale:
This if "hides" the dart_libfuzzer target for
build targets that do not support the fuzzer tool
(e.g. no asan, ia32, etc.). This makes "build all"
possible again, and yields "unknown target 'dart_libfuzzer'"
for unsupported case. Also updates README accordingly
and fixes some formatting.

#36774

Change-Id: I61d85ae00d13a0eda3818d40b992cd81f5ee0357
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100630
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
@aartbik aartbik closed this as completed Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aartbik aartbik

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aam @aartbik