Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The 'dart2aot' tool is missing from the Dart SDK debian package #36892

Closed
gabrielpacheco23 opened this issue May 8, 2019 · 9 comments
Closed

The 'dart2aot' tool is missing from the Dart SDK debian package #36892

gabrielpacheco23 opened this issue May 8, 2019 · 9 comments
Labels
area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@gabrielpacheco23
Copy link

gabrielpacheco23 commented May 8, 2019 •
edited
Loading

I can't use 'dart2aot' tool. I've already upgraded Dart to '2.3.1-dev' version.

Dart VM version: 2.3.1-dev.0.0 (Unknown timestamp) on "linux_x64"
dart2aot: command not found
@mraleph
Copy link
Member

mraleph commented May 8, 2019

How did you install the SDK?

/cc @mit-mit @cskau-g

@gabrielpacheco23
Copy link
Author

How did you install the SDK?

/cc @mit-mit @cskau-g

I've installed it using apt-get, as instructed by the Dart website (Linux Ubuntu 18.04)

@mraleph
Copy link
Member

mraleph commented May 8, 2019

@whesse @athomas Bill & Alex do you know if we need to update some scripts that generate ubuntu packages to have dart2aot included?

@whesse
Copy link
Contributor

whesse commented May 8, 2019

I believe the tools/linux_dist_support/debian directory controls how the debian packages are produced, and the build line is
https://github.com/dart-lang/sdk/blob/master/tools/linux_dist_support/debian/rules#L54
which runs tools/build.py create_sdk.

The contents of out/BUILD_DIR/dart-sdk are then copied and packaged up, so if dart2aot is in that directory, it will be included.

@athomas
Copy link
Member

athomas commented May 8, 2019

Yes, create_sdk is no longer sufficient, so we'll need to update the script for the debian package. dart2aot requires additional build steps:

https://github.com/dart-lang/sdk/blob/master/tools/bots/test_matrix.json#L1334

Workaround is to install the SDK from the zip file, those will include the tool (chocolatey & homebrew distributions will also have the tool). apt-get will not install it, and the docker images currently will not contain it.

@ghost
Copy link

ghost commented May 9, 2019

Installed via apt source, same issue here. would you please fix it ?

@ghost ghost self-assigned this May 9, 2019
@athomas athomas added the area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). label May 9, 2019
@mit-mit mit-mit changed the title How to install 'dart2aot' tool? The 'dart2aot' tool is missing from the Dart SDK debian package May 9, 2019
@mit-mit
Copy link
Member

mit-mit commented May 9, 2019 •
edited
Loading

For those needing this tool here and now, it should be in the 64-bit .zip bundles: https://dart.dev/tools/sdk/archive

@passsy passsy mentioned this issue May 14, 2019
Closed
dart-bot pushed a commit that referenced this issue May 29, 2019
Add new AOT build steps to deb package build script.
0d0f01a 
Bug: #36892
Change-Id: I6e8b202101449b2e8ca4c780ceca1e7e0731964c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101960
Commit-Queue: Clement Skau <cskau@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
@mit-mit
Copy link
Member

mit-mit commented Jun 3, 2019

@cskau-g was this resolved?

@mit-mit mit-mit added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Jun 3, 2019
@athomas
Copy link
Member

athomas commented Jun 3, 2019

Tested this on master, and it is resolved there.

The fix will likely be in the next dev release.

@athomas athomas closed this as completed Jun 3, 2019
@mit-mit mit-mit mentioned this issue Jun 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mraleph @whesse @mit-mit @athomas @gabrielpacheco23