-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flutter for web builds fail when const_update_2018 flag is turned on by default #37605
Labels
area-front-end
Use area-front-end for front end / CFE / kernel format related issues.
area-web
Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop.
P0
A serious issue requiring immediate resolution
web-dev-compiler
Milestone
Comments
Change needed to trigger the failure
|
/cc @johnniwinther |
/cc @yjbanov |
dart-bot
pushed a commit
that referenced
this issue
Jul 23, 2019
… constant" This reverts commit fd38424. Temporarily disabling this to get Flutter roll going. See #37605 TBR=nshahan@google.com Change-Id: I44dbb1d4aaf8d5f9cc05f096d26cade93a364f4c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110120 Reviewed-by: Vijay Menon <vsm@google.com> Commit-Queue: Vijay Menon <vsm@google.com>
I was able to repro this locally and have a fix locally that allows the build to complete. I will work on getting it landed ASAP. |
nshahan
added a commit
to flutter/engine
that referenced
this issue
Jul 23, 2019
Fixes: dart-lang/sdk#37605 We were seeing unevaluated constants during the build for flutter_web. Passing an empty map is handled differently than null so the constant evaluation will kick in.
dart-bot
pushed a commit
that referenced
this issue
Jul 24, 2019
… constant" This reverts commit 62674b9. Reason for revert: There is no reason we should ever encounter an unevaluated constant in DDK and doing so implies there is an error in the constant evaluation. We hope to find all such errors with this assertion. If this causes any more test failures, feel free to revert this again and create an issue so we can fix. A fix for the issue seen in the flutter-hhh bot has landed: flutter/engine#10069 Original change's description: > Revert "[dartdevc] Immediately throw when encountering an unevaluated constant" > > This reverts commit fd38424. > > Temporarily disabling this to get Flutter roll going. See > #37605 > > TBR=nshahan@google.com > > Change-Id: I44dbb1d4aaf8d5f9cc05f096d26cade93a364f4c > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110120 > Reviewed-by: Vijay Menon <vsm@google.com> > Commit-Queue: Vijay Menon <vsm@google.com> TBR=vsm@google.com,nshahan@google.com Change-Id: Ibcb719d3e6c0026b11a812bec853e158b338d51a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110185 Commit-Queue: Nicholas Shahan <nshahan@google.com> Reviewed-by: Nicholas Shahan <nshahan@google.com> Reviewed-by: Vijay Menon <vsm@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-front-end
Use area-front-end for front end / CFE / kernel format related issues.
area-web
Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop.
P0
A serious issue requiring immediate resolution
web-dev-compiler
The flutter for web engine builds fail with the following error when the const_update_2018 flag
is enabled. To reproduce checkout a flutter engine client and make local changes in
third_party/dart to enable const_update_2018 flag in the front end and try to build as follows
flutter/tools/gn --full-dart-sdk
ninja -C out/host_debug
This should trigger the error:
The text was updated successfully, but these errors were encountered: