-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
various segfaults #38231
Comments
|
|
|
|
|
There are a lot of these in our nightly. It seems to be all happening in
Easy to reproduce:
Also, unfortunately, this passes, pointing rather heavily to OSR (probably due to the new control-flow-collection testing):
|
Rationale: I need a bit more time to investigate the failures. No need to have massive amounts of divergences in our nightly in the meantime. #38231 Change-Id: I2fee0ba36292a2a38fce1d9a4727e5c4b74f0f1c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115842 Reviewed-by: Felicitas Hetzelt <felih@google.com> Commit-Queue: Aart Bik <ajcbik@google.com>
Fix out for review: |
Rationale: Let's stress test this feature again. Note that this will increase the number of skipped tests quite a bit since the CFE complains about a lot of the generated constructs. It is still TBD to find out if this is in the grammar or in the FE. #38231 Change-Id: Iec4bcb2aa9039f5b01293f82e3e156cc2e35414f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116663 Reviewed-by: Felicitas Hetzelt <felih@google.com> Reviewed-by: Ben Konyi <bkonyi@google.com> Commit-Queue: Aart Bik <ajcbik@google.com>
Rationale: Leaving a push argument on the stack in slightly more complex flow graphs (try-catch, loop back, conditinals) required a bit more bookkeeping. This CL also introduces more integrity checks to make sure the stack is as expected at each block and instruction. Note: Fuzzer is regression test for new feature. #38231 Change-Id: I8f7e605937d76c1a429df601e69380111737dd94 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116545 Commit-Queue: Aart Bik <ajcbik@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
The text was updated successfully, but these errors were encountered: