Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UBSAN (undefined behavior sanitizer) bot to our CI #39427

Closed
mkustermann opened this issue Nov 18, 2019 · 3 comments
Closed

Add UBSAN (undefined behavior sanitizer) bot to our CI #39427

mkustermann opened this issue Nov 18, 2019 · 3 comments
Assignees
@rmacnak-google
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@mkustermann
Copy link
Member

@alexmarkov pointed out some UB in a recent code review.

If we want to make our codebase clean of UB code, we should consider adding a UBSAN bot to our CI, similar to existing ASAN.

/cc @a-siva @mraleph
@mkustermann mkustermann added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Nov 18, 2019
@mkustermann mkustermann changed the title Add UBSAN (undefined behavior sanitizer) but to our CI Add UBSAN (undefined behavior sanitizer) bot to our CI Nov 18, 2019
@rmacnak-google
Copy link
Contributor

Related: 3678a3b

@rmacnak-google
Copy link
Contributor

Related: 6fe15f6

@rmacnak-google
Copy link
Contributor

Related: 60493d5

dart-bot pushed a commit that referenced this issue May 6, 2020
@rmacnak-google
[vm] Prevent try index from clobbering yield index when encoding pc d…
9a4b464 
…escriptors.

Bug: #39427
Change-Id: I81beb5b269857e486a7374968fe8ac78d72bb16b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146695
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
dart-bot pushed a commit that referenced this issue May 7, 2020
@rmacnak-google
[vm] Use consistent signatures for native call wrappers and native fu…
9e5dbad 
…nction symbolizers.

Bug: #39427
Change-Id: I0d52d935c15f4d01d56e5e99bc4b83b31678a6ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146940
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
dart-bot pushed a commit that referenced this issue May 7, 2020
@rmacnak-google
[vm] Fix various UBSan failures.
2707880 
Bug: #39427
Change-Id: I74e0eee623d88005fb2893d03e284a87daa09260
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146696
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
dart-bot pushed a commit that referenced this issue May 11, 2020
@rmacnak-google
[infra] Add UBSan bots.
7ea0c55 
Bug: #39427
Change-Id: I9d40f9f3e402b5aba46badcccfada6e891df0755
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146981
Reviewed-by: Alexander Thomas <athom@google.com>
dart-bot pushed a commit that referenced this issue May 12, 2020
@rmacnak-google
[infra] Recognize the exit code for UBSAN failures.
cb46dbb 
This seems to only affect the bots and not local runs of test.py.

Bug: #39427
Change-Id: I3d80fc662a29585416a61f454b21f977853c0e71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147621
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: William Hesse <whesse@google.com>
dart-bot pushed a commit that referenced this issue May 12, 2020
@rmacnak-google
[vm] Fix various UBSan failures: ARM.
17f3bf9 
Bug: #39427
Change-Id: Ie6ba61d699c1ea51310e15b924fb58cb02cf6e1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146989
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
dart-bot pushed a commit that referenced this issue May 12, 2020
@rmacnak-google
[vm] Fix various UBSan failures: AOT.
40d8763 
Bug: #39427
Change-Id: I2594e28a277f1d9f838aa93d546714d4f300b5b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147682
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
dart-bot pushed a commit that referenced this issue May 13, 2020
@rmacnak-google
[infra] Accept 1 as a test exit code only in UBSAN configurations.
ead5838 
Bug: #39427
Change-Id: Icd5460c6127209a8c811baa42709053878ff3923
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147811
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
dart-bot pushed a commit that referenced this issue May 13, 2020
@rmacnak-google
[vm] Fix vm/cc/DartGeneratedArrayLiteralMessages.
60297d4 
This was broken by Dart 2. It failed in a way that also triggered UBSAN.

Bug: #39427
Change-Id: Ie7d5f3e7ef6b8af683073a18abf759b750ce2c43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147818
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
tekknolagi pushed a commit to tekknolagi/dart-assembler that referenced this issue Nov 3, 2020
@rmacnak-google
[vm] Fix various UBSan failures.
bd6ec52 
Bug: dart-lang#39427
Change-Id: I74e0eee623d88005fb2893d03e284a87daa09260
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146696
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
tekknolagi pushed a commit to tekknolagi/dart-assembler that referenced this issue Nov 3, 2020
@rmacnak-google
[vm] Fix various UBSan failures: ARM.
77aefe7 
Bug: dart-lang#39427
Change-Id: Ie6ba61d699c1ea51310e15b924fb58cb02cf6e1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146989
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmacnak-google rmacnak-google

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkustermann @rmacnak-google