Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support timeline conversion to iOS platform trace #40076

Closed
yuanhuihui opened this issue Jan 13, 2020 · 2 comments
Closed

Support timeline conversion to iOS platform trace #40076

yuanhuihui opened this issue Jan 13, 2020 · 2 comments
Assignees
@bkonyi
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@yuanhuihui
Copy link
Contributor

yuanhuihui commented Jan 13, 2020 •
edited
Loading

As of now, timeline can be better converted to systrace of Android platform(see flutter/flutter#47771). This PR is in order to support the trace function converted to the instruments of iOS platform.

something needs to be explained:

I redefine the macro OS_LOG_CALL_WITH_FORMAT_NAME to remove the constraint that the name must be argument must be a string constant in OS_LOG_STRING, otherwise it will run out of error as below:

error: static_assert failed due to requirement '__builtin_constant_p(str1)' "format/label/description argument must be a string constant"

run application with --systrace, we can see that the timeline events are all converted to the instruments IDE:

789a5d9f-8e2d-4696-8f75-c97416933e47
@yuanhuihui
Copy link
Contributor Author

https://dart-review.googlesource.com/c/sdk/+/131360

@yuanhuihui
Copy link
Contributor Author

relation to flutter/flutter#47771

@lrhn lrhn added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Jan 13, 2020
dart-bot pushed a commit that referenced this issue Jan 17, 2020
@yuanhuihui
Support timeline conversion to iOS platform trace
72b0501 
using Instruments to track these events.

Signed-off-by: yuanhuihui <gityuan@gmail.com>
Bug: #40076
Change-Id: I590081c516923f82a2a3dbf4b109afe75b8f5fc5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131360
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
@bkonyi bkonyi closed this as completed Feb 5, 2020
@kenzieschmoll kenzieschmoll mentioned this issue Feb 6, 2020
Open
@yuanhuihui yuanhuihui mentioned this issue Feb 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkonyi bkonyi

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yuanhuihui @lrhn @bkonyi