Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NNBD bot build failed #40409

Closed
zichangg opened this issue Jan 30, 2020 · 1 comment
Closed

NNBD bot build failed #40409

zichangg opened this issue Jan 30, 2020 · 1 comment
Assignees
@liamappelbe
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). gardening

Comments

@zichangg
Copy link
Contributor

The bots are failing now.

https://ci.chromium.org/p/dart/builders/ci.sandbox/vm-kernel-nnbd-linux-debug-x64/380

https://ci.chromium.org/p/dart/builders/ci.sandbox/vm-kernel-nnbd-linux-release-x64/388

@liamappelbe Any idea?
@liamappelbe
Copy link
Contributor

yep, working on it

dart-bot pushed a commit that referenced this issue Jan 30, 2020
@liamappelbe
[vm] Reland the flag flip behind the --nnbd build flag
00e481a 
Bug: #40409
Bug: #40179
Change-Id: Ib84926ef15068d23dcac7b89843c454b8446b28e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134062
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
@srawlins srawlins added the area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liamappelbe liamappelbe

Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). gardening
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@srawlins @liamappelbe @zichangg