Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Training run of 'pub' in the SDK build fails #40486

Closed
a-siva opened this issue Feb 6, 2020 · 0 comments · Fixed by flutter/engine#16813
Closed

Training run of 'pub' in the SDK build fails #40486

a-siva opened this issue Feb 6, 2020 · 0 comments · Fixed by flutter/engine#16813
Assignees
@a-siva
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. NNBD Issues related to NNBD Release

Comments

@a-siva
Copy link
Contributor

a-siva commented Feb 6, 2020

The training run on 'pub' in the SDK build fails with the following error :

Closure: ([Object]) => void? from _AsyncCompleter@9048458.complete_complete
'dart:async/future_impl.dart': Failed type check: line 117 pos 21: type '([Object]) => void?' is not a subtype of type '(dynamic?) => FutureOr<void?>' in type cast

To reproduce:

Patch in the CL https://dart-review.googlesource.com/c/sdk/+/134112 and build a full SDK using tools/build.py --nnbd create_sdk

Run "pub help <command>" for more information about a command.
See https://dart.dev/tools/pub/cmd for detailed documentation.
null
Closure: ([Object]) => void? from _AsyncCompleter@9048458.complete_complete
'dart:async/future_impl.dart': Failed type check: line 117 pos 21: type '([Object]) => void?' is not a subtype of type '(dynamic?) => FutureOr<void?>' in type cast
Exception 'Instance of '_CastError'' thrown:
#0      _FutureListener._onValue (dart:async/future_impl.dart:117:21)
#1      _FutureListener.handleValue (dart:async/future_impl.dart:141:43)
#2      Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:690:45)
#3      Future._propagateToListeners (dart:async/future_impl.dart:719:32)
#4      Future._completeWithValue (dart:async/future_impl.dart:529:5)
#5      Future._asyncComplete.<anonymous closure> (dart:async/future_impl.dart:561:7)
#6      _rootRun (dart:async/zone.dart:1134:13)
#7      _CustomZone.run (dart:async/zone.dart:1038:19)
#8      _CustomZone.runGuarded (dart:async/zone.dart:942:7)
#9      _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:982:23)
#10     _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
#11     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
#12     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:117:13)
#13     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:168:5)
@a-siva a-siva added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. NNBD Issues related to NNBD Release labels Feb 6, 2020
@a-siva a-siva self-assigned this Feb 6, 2020
skia-flutter-autoroll added a commit to skia-flutter-autoroll/engine that referenced this issue Feb 26, 2020
@skia-flutter-autoroll
Roll src/third_party/dart 85f6d51..bf34450 (24 commits)
a213b3a 
https://dart.googlesource.com/sdk.git/+log/85f6d51c3fd1..bf34450953eb

git log 85f6d51..bf34450 --date=short --first-parent --format='%ad %ae %s'
2020-02-26 asiva@google.com Remove workaround introduced for issue flutter#40486, that issue appears to be fixed now. Closes dart-lang/sdk#40486
2020-02-26 rmacnak@google.com Revert "[vm] Re-land aggressive write-barrier elimination."
2020-02-26 rnystrom@google.com Migrate css_selector_test off unittest.
2020-02-26 athom@google.com [infra] Add strong mode testing to the CFE builder
2020-02-26 scheglov@google.com Issue 40413. Don't infer promoted TypeParameterType(s) for locals.
2020-02-26 nbosch@google.com Remove some stale JS interop known differences
2020-02-26 liama@google.com [vm] Add required flag to parameters, and implement subtyping rules.
2020-02-26 devoncarew@google.com add the 'console-full' stagehand template
2020-02-26 regis@google.com [VM/nnbd] Check nullability of function types in strong mode (fixes flutter#39820).
2020-02-25 pquitslund@google.com clone and update corpus repos
2020-02-25 aam@google.com [vm/vmservice] Validate getIsolate response before attempting to retrieve pauseEvent from it.
2020-02-25 alexmarkov@google.com [tests/nnbd] Fix language/async_star/throw_in_catch_test
2020-02-25 pquitslund@google.com itsallwidgets corpus repo data
2020-02-25 jwren@google.com Additional flags on the dartdev analyze command: --fatal-warnings and --fatal-infos
2020-02-25 keertip@google.com Add an interface for a workspace with a default analysis options file
2020-02-25 scheglov@google.com Update tests expectations with DEAD_NULL_AWARE_EXPRESSION.
2020-02-25 scheglov@google.com Update String.splitMapJoin() in MockSdk to the style in unforked SDK, fail a test.
2020-02-25 brianwilkerson@google.com Stop gathering information about the class of child nodes
2020-02-25 alexmarkov@google.com [vm/nnbd] Rename --strong-non-nullable-type-checks to --null-safety and pass it to CFE
2020-02-25 alexmarkov@google.com [vm/nnbd] Add --null-safety option to VM's kernel compilers
2020-02-25 brianwilkerson@google.com Fix a RangeError in LSP completions
2020-02-25 zichangguo@google.com [dart:io] issue another read in _NativeSocket.read to drain pipe
2020-02-25 joshualitt@google.com [dart2js] Fix names for late static fields.
2020-02-25 scheglov@google.com Use parseString() API instead of internal Parser.

Created with:
  gclient setdep -r src/third_party/dart@bf34450953eb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: dart-vm-team@google.com
This was referenced Feb 26, 2020
Closed
Closed
skia-flutter-autoroll added a commit to skia-flutter-autoroll/engine that referenced this issue Feb 26, 2020
@skia-flutter-autoroll
Roll src/third_party/dart 85f6d51..53c59d9 (26 commits)
41dec96 
https://dart.googlesource.com/sdk.git/+log/85f6d51c3fd1..53c59d9f4e22

git log 85f6d51..53c59d9 --date=short --first-parent --format='%ad %ae %s'
2020-02-26 johnniwinther@google.com [cfe] Fix uri in non-nullable field error reporting
2020-02-26 jensj@google.com [CFE] Fixes to experimental invalidation strategy
2020-02-26 asiva@google.com Remove workaround introduced for issue flutter#40486, that issue appears to be fixed now. Closes dart-lang/sdk#40486
2020-02-26 rmacnak@google.com Revert "[vm] Re-land aggressive write-barrier elimination."
2020-02-26 rnystrom@google.com Migrate css_selector_test off unittest.
2020-02-26 athom@google.com [infra] Add strong mode testing to the CFE builder
2020-02-26 scheglov@google.com Issue 40413. Don't infer promoted TypeParameterType(s) for locals.
2020-02-26 nbosch@google.com Remove some stale JS interop known differences
2020-02-26 liama@google.com [vm] Add required flag to parameters, and implement subtyping rules.
2020-02-26 devoncarew@google.com add the 'console-full' stagehand template
2020-02-26 regis@google.com [VM/nnbd] Check nullability of function types in strong mode (fixes flutter#39820).
2020-02-25 pquitslund@google.com clone and update corpus repos
2020-02-25 aam@google.com [vm/vmservice] Validate getIsolate response before attempting to retrieve pauseEvent from it.
2020-02-25 alexmarkov@google.com [tests/nnbd] Fix language/async_star/throw_in_catch_test
2020-02-25 pquitslund@google.com itsallwidgets corpus repo data
2020-02-25 jwren@google.com Additional flags on the dartdev analyze command: --fatal-warnings and --fatal-infos
2020-02-25 keertip@google.com Add an interface for a workspace with a default analysis options file
2020-02-25 scheglov@google.com Update tests expectations with DEAD_NULL_AWARE_EXPRESSION.
2020-02-25 scheglov@google.com Update String.splitMapJoin() in MockSdk to the style in unforked SDK, fail a test.
2020-02-25 brianwilkerson@google.com Stop gathering information about the class of child nodes
2020-02-25 alexmarkov@google.com [vm/nnbd] Rename --strong-non-nullable-type-checks to --null-safety and pass it to CFE
2020-02-25 alexmarkov@google.com [vm/nnbd] Add --null-safety option to VM's kernel compilers
2020-02-25 brianwilkerson@google.com Fix a RangeError in LSP completions
2020-02-25 zichangguo@google.com [dart:io] issue another read in _NativeSocket.read to drain pipe
2020-02-25 joshualitt@google.com [dart2js] Fix names for late static fields.
2020-02-25 scheglov@google.com Use parseString() API instead of internal Parser.

Created with:
  gclient setdep -r src/third_party/dart@53c59d9f4e22

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: dart-vm-team@google.com
skia-flutter-autoroll added a commit to skia-flutter-autoroll/engine that referenced this issue Feb 26, 2020
@skia-flutter-autoroll
Roll src/third_party/dart 85f6d51..4189237 (30 commits)
51987c7 
https://dart.googlesource.com/sdk.git/+log/85f6d51c3fd1..418923733006

git log 85f6d51..4189237 --date=short --first-parent --format='%ad %ae %s'
2020-02-26 johnniwinther@google.com [cfe] Avoid crash on Never as bound
2020-02-26 jensj@google.com [CFE] Set InvalidLanguageVersion if in fact invalid, fix a lookup bug
2020-02-26 whesse@google.com [infra] Send a tryjob's base commit hash when publishing results to pubsub
2020-02-26 johnniwinther@google.com [cfe] Handle future or fields
2020-02-26 johnniwinther@google.com [cfe] Fix uri in non-nullable field error reporting
2020-02-26 jensj@google.com [CFE] Fixes to experimental invalidation strategy
2020-02-26 asiva@google.com Remove workaround introduced for issue flutter#40486, that issue appears to be fixed now. Closes dart-lang/sdk#40486
2020-02-26 rmacnak@google.com Revert "[vm] Re-land aggressive write-barrier elimination."
2020-02-26 rnystrom@google.com Migrate css_selector_test off unittest.
2020-02-26 athom@google.com [infra] Add strong mode testing to the CFE builder
2020-02-26 scheglov@google.com Issue 40413. Don't infer promoted TypeParameterType(s) for locals.
2020-02-26 nbosch@google.com Remove some stale JS interop known differences
2020-02-26 liama@google.com [vm] Add required flag to parameters, and implement subtyping rules.
2020-02-26 devoncarew@google.com add the 'console-full' stagehand template
2020-02-26 regis@google.com [VM/nnbd] Check nullability of function types in strong mode (fixes flutter#39820).
2020-02-25 pquitslund@google.com clone and update corpus repos
2020-02-25 aam@google.com [vm/vmservice] Validate getIsolate response before attempting to retrieve pauseEvent from it.
2020-02-25 alexmarkov@google.com [tests/nnbd] Fix language/async_star/throw_in_catch_test
2020-02-25 pquitslund@google.com itsallwidgets corpus repo data
2020-02-25 jwren@google.com Additional flags on the dartdev analyze command: --fatal-warnings and --fatal-infos
2020-02-25 keertip@google.com Add an interface for a workspace with a default analysis options file
2020-02-25 scheglov@google.com Update tests expectations with DEAD_NULL_AWARE_EXPRESSION.
2020-02-25 scheglov@google.com Update String.splitMapJoin() in MockSdk to the style in unforked SDK, fail a test.
2020-02-25 brianwilkerson@google.com Stop gathering information about the class of child nodes
2020-02-25 alexmarkov@google.com [vm/nnbd] Rename --strong-non-nullable-type-checks to --null-safety and pass it to CFE
2020-02-25 alexmarkov@google.com [vm/nnbd] Add --null-safety option to VM's kernel compilers
2020-02-25 brianwilkerson@google.com Fix a RangeError in LSP completions
2020-02-25 zichangguo@google.com [dart:io] issue another read in _NativeSocket.read to drain pipe
2020-02-25 joshualitt@google.com [dart2js] Fix names for late static fields.
2020-02-25 scheglov@google.com Use parseString() API instead of internal Parser.

Created with:
  gclient setdep -r src/third_party/dart@418923733006

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: dart-vm-team@google.com
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a-siva a-siva

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. NNBD Issues related to NNBD Release
Projects
None yet
Milestone
No milestone
1 participant
@a-siva