Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

../../runtime/lib/mirrors.cc: 1705: error: expected: !script.IsNull() #40497

Closed
a-siva opened this issue Feb 6, 2020 · 0 comments
Closed

../../runtime/lib/mirrors.cc: 1705: error: expected: !script.IsNull() #40497

a-siva opened this issue Feb 6, 2020 · 0 comments
Assignees
@rmacnak-google
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. NNBD Issues related to NNBD Release
Projects
Dart VM support for Null Safe feature

Comments

@a-siva
Copy link
Contributor

a-siva commented Feb 6, 2020

The switch to NNBD libraries causes a mirrors test to fail

/======================================================================\
| lib/mirrors/mirrors_reader_test broke (Pass -> Crash, expected Pass) |
\======================================================================/

--- Command "vm" (took 09.000610s):
DART_CONFIGURATION=DebugX64NNBD out/DebugX64NNBD/dart --enable_asserts --enable-experiment=non-nullable --ignore-unrecognized-flags --packages=/b/s/w/ir/cache/builder/sdk/.packages /b/s/w/ir/cache/builder/sdk/tests/lib/mirrors/mirrors_reader_test.dart

exit code:
-6

stderr:
../../runtime/lib/mirrors.cc: 1705: error: expected: !script.IsNull()
version=2.8.0-edge.49850e6919f7802224777770041835c9c6ca1a6f (Thu Feb 6 21:06:11 2020 +0000) on "linux_x64"
thread=5104, isolate=main(0x55f8217a7800)
isolate_instructions=55f81eaace60, vm_instructions=55f81eaace60
  pc 0x000055f81ee8069c fp 0x00007f1227c7ae50 dart::Profiler::DumpStackTrace(void*)
  pc 0x000055f81eaaa6d2 fp 0x00007f1227c7af30 dart::Assert::Fail(char const*, ...)
  pc 0x000055f81ec6d7c6 fp 0x00007f1227c7af90 dart::BootstrapNatives::DN_DeclarationMirror_location(dart::Thread*, dart::Zone*, dart::NativeArguments*)
  pc 0x000055f81ed9b6c8 fp 0x00007f1227c7b000 dart::NativeEntry::BootstrapNativeCallWrapper(_Dart_NativeArguments*, void (*)(_Dart_NativeArguments*))
  pc 0x00007f1228c81219 fp 0x00007f1227c7b048 Unknown symbol
@a-siva a-siva added area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. NNBD Issues related to NNBD Release labels Feb 6, 2020
@a-siva a-siva added this to Needs triage in Dart VM support for Null Safe feature via automation Feb 6, 2020
@a-siva a-siva moved this from Needs triage to Null Safe SDK complete in Dart VM support for Null Safe feature Feb 6, 2020
@a-siva a-siva assigned a-siva and rmacnak-google and unassigned a-siva Feb 6, 2020
dart-bot pushed a commit that referenced this issue Feb 7, 2020
@rmacnak-google
[vm, lib] Teach mirrors about the Never type and member signatures.
a73b0ce 
Bug: #12478
Bug: #40497
Bug: #40510
Change-Id: I841d7e239b8235555ec26fbcb74ca41b5de60f58
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134806
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
dart-bot pushed a commit that referenced this issue Feb 10, 2020
@rmacnak-google
[vm] Further mirrors and test fixes.
0fde59b 
Bug: #40497
Change-Id: Ieed8a51600f92fa4dc9137bf1f4ed58bb4cfa598
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134900
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
@a-siva a-siva closed this as completed Feb 12, 2020
Dart VM support for Null Safe feature automation moved this from Null Safe SDK complete to Done Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmacnak-google rmacnak-google

Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. NNBD Issues related to NNBD Release
Projects
Dart VM support for Null Safe feature
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rmacnak-google @a-siva