Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart:mirrors does not account for nullability #40510

Closed
rmacnak-google opened this issue Feb 7, 2020 · 8 comments
Closed

dart:mirrors does not account for nullability #40510

rmacnak-google opened this issue Feb 7, 2020 · 8 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-not-planned Closed as we don't intend to take action on the reported issue library-mirrors type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) vm-nnbd-sdk-complete All new NNBD and ported NNBD tests pass
Projects
Dart VM support for Null Safe feature

Comments

@rmacnak-google
Copy link
Contributor

TypeMirror.isSubtypeOf and TypeMirror.isAssignableTo do not account for recent language breakage.

TypeMirror.isNullable should be added.
@rmacnak-google rmacnak-google added area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-mirrors vm-nnbd-sdk-complete All new NNBD and ported NNBD tests pass labels Feb 7, 2020
@a-siva a-siva added this to Needs triage in Dart VM support for Null Safe feature via automation Feb 7, 2020
@a-siva a-siva moved this from Needs triage to Null Safe SDK complete in Dart VM support for Null Safe feature Feb 7, 2020
dart-bot pushed a commit that referenced this issue Feb 7, 2020
@rmacnak-google
[vm, lib] Teach mirrors about the Never type and member signatures.
a73b0ce 
Bug: #12478
Bug: #40497
Bug: #40510
Change-Id: I841d7e239b8235555ec26fbcb74ca41b5de60f58
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134806
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
@a-siva
Copy link
Contributor

a-siva commented May 13, 2020

@rmacnak-google is this something you are looking at adding ?

This was referenced Aug 17, 2020
Closed
Closed
@lrhn
Copy link
Member

lrhn commented Aug 18, 2020

The dart:mirrors library does not account for nullability at all. There is no understanding of nullable types at all.
The library will need to be migrated.

@leafpetersen leafpetersen added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Sep 3, 2020
@franklinyow
Copy link
Contributor

Any update on this?

@a-siva
Copy link
Contributor

a-siva commented Sep 15, 2020

the dart:mirrors library is in maintenance mode and I would prefer if we did not add any new functionality or APIs to it.

@lrhn lrhn mentioned this issue Sep 16, 2020
Closed
@franklinyow
Copy link
Contributor

@a-siva Can this be move out of the beta Epic?

@a-siva
Copy link
Contributor

a-siva commented Sep 28, 2020

Yes we should move it out of the beta Epic.

@a-siva a-siva moved this from Null Safe SDK complete to Null Safe SDK Beta (Flutter Framework + Core Packages Migrated) in Dart VM support for Null Safe feature Sep 28, 2020
@pouyakary
Copy link

Any progress?

@a-siva
Copy link
Contributor

a-siva commented Aug 5, 2022

@pouyakary at this point we have no plans for making dart:mirrors library account for nullability.
Please see #44489 which is investigating a path towards discontinuing support for dart:mirrors

@a-siva a-siva added the closed-not-planned Closed as we don't intend to take action on the reported issue label Aug 5, 2022
@a-siva a-siva closed this as completed Aug 5, 2022
Dart VM support for Null Safe feature automation moved this from Null Safe SDK Beta (Flutter Framework + Core Packages Migrated) to Done Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-not-planned Closed as we don't intend to take action on the reported issue library-mirrors type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) vm-nnbd-sdk-complete All new NNBD and ported NNBD tests pass
Projects
Dart VM support for Null Safe feature
  
Done
Milestone
No milestone
Development

No branches or pull requests
6 participants
@pouyakary @lrhn @leafpetersen @rmacnak-google @a-siva @franklinyow