Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --force-nnbd-checks guard for nnbd warnings/errors in CFE #40980

Closed
johnniwinther opened this issue Mar 11, 2020 · 0 comments
Closed

Remove --force-nnbd-checks guard for nnbd warnings/errors in CFE #40980

johnniwinther opened this issue Mar 11, 2020 · 0 comments
Assignees
@chloestefantsova
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. NNBD Issues related to NNBD Release

Comments

@johnniwinther
Copy link
Member

No description provided.

@johnniwinther johnniwinther added area-front-end Use area-front-end for front end / CFE / kernel format related issues. NNBD Issues related to NNBD Release labels Mar 11, 2020
@johnniwinther johnniwinther mentioned this issue Mar 11, 2020
Closed
This was referenced Mar 11, 2020
Closed
Closed
dart-bot pushed a commit that referenced this issue Mar 13, 2020
Pass --force-nnbd-checks whenever NNBD experiment is enabled
25d7331 
This is a preliminary step before removing the flag completely.

Bug: #40980
Change-Id: Ib2135180aa0f30dd301beaacb842105096f8948c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139289
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chloestefantsova chloestefantsova

Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. NNBD Issues related to NNBD Release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chloestefantsova @johnniwinther