Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define an API (and process for updating) debug metadata files #41852

Open
nshahan opened this issue May 11, 2020 · 0 comments
Open

Define an API (and process for updating) debug metadata files #41852

nshahan opened this issue May 11, 2020 · 0 comments
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P2 A bug or feature request we're likely to work on web-dev-compiler

Comments

@nshahan
Copy link
Contributor

nshahan commented May 11, 2020

We are experimenting with adding new output artifacts alongside JS files to pass information directly to debug tools.

To avoid breaking workflows we need a clear process for updating the location or contents of these files before adding dependencies on them to tooling outside of the SDK.

Parts of a possible solution include:

  • Introduce a package that handles IO with these files.
  • Pin the SDK version in some packages.
  • Document a clear process of rolling out breaking changes, what packages need to be updated,
    in what order, etc.
@nshahan nshahan added P2 A bug or feature request we're likely to work on web-dev-compiler area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. labels May 11, 2020
@annagrin annagrin mentioned this issue May 13, 2020
Open
dart-bot pushed a commit that referenced this issue Jun 20, 2020
Added module information to metadata and use by frontend_sever
c909e16 
- created class representing module metadata, added metadata to JsCode
  class
- added module information to metadata, such as module name, load
  function name
- added import and file uris for libraries
- added experimental-emit-debug-metadata flag to frontend_server
- added frontend server tests to check for saved metadata

Related: #41852
Closes: #40774
Change-Id: Iecbbf1e4eea1919e01f002f45363d30707cb1590
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150181
Commit-Queue: Anna Gringauze <annagrin@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Gary Roumanis <grouma@google.com>
@annagrin annagrin mentioned this issue Jul 10, 2020
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P2 A bug or feature request we're likely to work on web-dev-compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nshahan