Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures on [ddc] Add --sound-null-safety flag and pass to CFE #42107

Closed
nshahan opened this issue May 28, 2020 · 2 comments
Closed

Failures on [ddc] Add --sound-null-safety flag and pass to CFE #42107

nshahan opened this issue May 28, 2020 · 2 comments
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. NNBD Issues related to NNBD Release web-dev-compiler

Comments

@nshahan
Copy link
Contributor

nshahan commented May 28, 2020

There are new test failures on [ddc] Add --sound-null-safety flag and pass to CFE.

The tests

dartdevc_native/assertion_failure_message_test CompileTimeError (expected Pass)
dartdevc_native/const_test CompileTimeError (expected Pass)
dartdevc_native/debugger/debugger_test CompileTimeError (expected Pass)
dartdevc_native/hot_restart_test CompileTimeError (expected Pass)
dartdevc_native/hot_restart_timer_test CompileTimeError (expected Pass)
dartdevc_native/js_interop_test CompileTimeError (expected Pass)
dartdevc_native/libraries_test CompileTimeError (expected Pass)
dartdevc_native/no_such_method_errors_test CompileTimeError (expected Pass)
dartdevc_native/subtype_test CompileTimeError (expected Pass)
dartdevc_native/variance_subtype_test CompileTimeError (expected Pass)
dartdevc_native/variance_test CompileTimeError (expected Pass)

are failing on configurations

dartdevk-strong-linux-release-chrome

These tests need to be updated, forked, or deleted because they cannot run with in sound null safety mode with opted out files.
@nshahan nshahan added web-dev-compiler area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. NNBD Issues related to NNBD Release labels May 28, 2020
@nshahan
Copy link
Contributor Author

nshahan commented Jul 13, 2020

FYI these tests have been migrated to tests/dartdevc and tests/dartdevc_2.

dart-bot pushed a commit that referenced this issue Jul 15, 2020
@nshahan
[ddc] Fix variance test migration to null safety
461d01c 
Change-Id: I5f6e446c72ae1a41d92f419eb57a8dd030a70372
Issue: #42107
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154292
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
dart-bot pushed a commit that referenced this issue Jul 15, 2020
@nshahan
[ddc] Migrate tests in dartdevc suite
1332cf8 
Change-Id: I2a35de7f79b8d768cdd0144b3bf5de87fa929942
Issue: #42107
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154301
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Joshua Litt <joshualitt@google.com>
@nshahan
Copy link
Contributor Author

nshahan commented Jul 15, 2020

The migrated tests have been fixed and should now be at parity with their "_2" counterparts.

@nshahan nshahan closed this as completed Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. NNBD Issues related to NNBD Release web-dev-compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nshahan