Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 21st century terms in the SDK repo #42247

Closed
kevmoo opened this issue Jun 9, 2020 · 8 comments
Closed

Use 21st century terms in the SDK repo #42247

kevmoo opened this issue Jun 9, 2020 · 8 comments
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@kevmoo
Copy link
Member

kevmoo commented Jun 9, 2020 •
edited
Loading

See https://developers.google.com/style/word-list RE allow/block list, master/slave alternatives etc

Will require work items across different components.
@kevmoo kevmoo added area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Jun 9, 2020
@kevmoo
Copy link
Member Author

kevmoo commented Jun 9, 2020

CC @vsmenon

@mit-mit
Copy link
Member

mit-mit commented Jun 10, 2020

First CL: https://dart-review.googlesource.com/c/sdk/+/150623

dart-bot pushed a commit that referenced this issue Jun 10, 2020
@mit-mit
Use terms which are not divisive
9cca0f7 
Based on guidance in https://developers.google.com/style/inclusive-documentation

Related to #42247

Change-Id: Iaed8db465ae6a78cce3688b695287898c36e4734
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150623
Auto-Submit: Michael Thomsen <mit@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
@mit-mit
Copy link
Member

mit-mit commented Jun 10, 2020

Second CL: https://dart-review.googlesource.com/c/sdk/+/150626

mit-mit added a commit to dart-lang/pub-dev that referenced this issue Jun 10, 2020
@mit-mit
Update markdown.dart
3ce4b48 
Related to dart-lang/sdk#42247
@mit-mit mit-mit mentioned this issue Jun 10, 2020
Merged
mit-mit added a commit to dart-lang/pub that referenced this issue Jun 10, 2020
@mit-mit
Remove divisive term
d8b181f 
Related to dart-lang/sdk#42247
@mit-mit mit-mit mentioned this issue Jun 10, 2020
Merged
isoos pushed a commit to dart-lang/pub-dev that referenced this issue Jun 10, 2020
@mit-mit
Update markdown.dart (#3704)
4006888 
Related to dart-lang/sdk#42247
@mit-mit
Copy link
Member

mit-mit commented Jun 10, 2020

Updates in scripts: https://dart-review.googlesource.com/c/sdk/+/150629/

@mit-mit
Copy link
Member

mit-mit commented Jun 10, 2020

Runtime changes: https://dart-review.googlesource.com/c/sdk/+/150630

dart-bot pushed a commit that referenced this issue Jun 10, 2020
@mit-mit
Avoid divisive terms
41a7db1 
Based on guidance in https://developers.google.com/style/w

Related to #42247

Change-Id: If40c8e39bb35f1f7dfad9cb977c7a494a2cc3bd7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150626
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
@mit-mit
Copy link
Member

mit-mit commented Jun 10, 2020

Test changes in https://dart-review.googlesource.com/c/sdk/+/150632

dart-bot pushed a commit that referenced this issue Jun 10, 2020
@mit-mit
Change terms to be more divisive
8d65076 
Based on guidance in https://developers.google.com/style/

Related to #42247

Change-Id: Ia4edb2cb0540781f1119c369406a7b65553e26f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150632
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
dart-bot pushed a commit that referenced this issue Jun 10, 2020
@athomas
[infra] Remove obsolete buildbot paths/terms
1e5b018 
#42247

Change-Id: Ia0b19677c655bc768f00be77df8b0162ac9e7bea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150629
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
@sigurdm sigurdm mentioned this issue Jun 12, 2020
Merged
@mit-mit
Copy link
Member

mit-mit commented Jun 15, 2020

@mraleph did you have an alternate PR for https://dart-review.googlesource.com/c/sdk/+/150630 ?

dart-bot pushed a commit that referenced this issue Jun 17, 2020
@mraleph
Remove divisive terms
025d256 
Based on guidance in https://developers.google.com/style/

Related to #42247

Change-Id: Iaf37f3372b2b5882738cfa63339dd7b032cdbba9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150630
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
@mit-mit
Copy link
Member

mit-mit commented Jun 17, 2020

I believe this is now complete

@mit-mit mit-mit closed this as completed Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevmoo @mit-mit