Customer-reported issue with NNBD migration tool: Could not load edit details

[timsneath]

Could not load edit details

Error: FormatException: Invalid port (at character 18)
http://127.0.0.1:49968structs.dart
                 ^

Please fill in the following:

Name of package being migrated (if public):
https://github.com/timsneath/win32

What I was doing when this issue occurred:
Made one change in structs.dart and then clicked on the right-hand nav to make another change

Is it possible to work around this issue:
Only by reapplying,

Has this issue happened before, and if so, how often:
Dart SDK version: 2.9.0-20.0.dev.flutter-06cb010247
Additional details:

Thanks for filing!

Stacktrace: auto populated by migration preview tool.

FormatException: Invalid port (at character 18)
http://127.0.0.1:49968structs.dart
                 ^

    at Object.b (http://127.0.0.1:49968/C:/src/win32/lib/src/exceptions.dart?authToken=f6xUMqAyErk%3D:260:3)
    at Object.vh (http://127.0.0.1:49968/C:/src/win32/lib/src/exceptions.dart?authToken=f6xUMqAyErk%3D:267:24)
    at Object.hK (http://127.0.0.1:49968/C:/src/win32/lib/src/exceptions.dart?authToken=f6xUMqAyErk%3D:2088:18)
    at Object.Fr (http://127.0.0.1:49968/C:/src/win32/lib/src/exceptions.dart?authToken=f6xUMqAyErk%3D:3362:50)
    at http://127.0.0.1:49968/C:/src/win32/lib/src/exceptions.dart?authToken=f6xUMqAyErk%3D:3201:3
    at Gs.a (http://127.0.0.1:49968/C:/src/win32/lib/src/exceptions.dart?authToken=f6xUMqAyErk%3D:1513:72)
    at Gs.$2 (http://127.0.0.1:49968/C:/src/win32/lib/src/exceptions.dart?authToken=f6xUMqAyErk%3D:4389:23)
    at WM.$1 (http://127.0.0.1:49968/C:/src/win32/lib/src/exceptions.dart?authToken=f6xUMqAyErk%3D:4381:30)
    at Ji.bv (http://127.0.0.1:49968/C:/src/win32/lib/src/exceptions.dart?authToken=f6xUMqAyErk%3D:4655:25)
    at rq.$0 (http://127.0.0.1:49968/C:/src/win32/lib/src/exceptions.dart?authToken=f6xUMqAyErk%3D:4583:11)

[timsneath]

Screenshot in case it helps:

[creativecreatorormaybenot]

Can confirm, this happens all the time with every edit for me.

[kevmoo]

CC @MichaelRFairhurst @stereotype441

[stereotype441]

Thanks for the bug report! I'm able to reproduce this. Investigating...

[DanTup]

I don't know if it's the same issue, but on the latest nightly on Windows I get a lot of errorpopups like this:

Could not add/remove hint
or
Could not load dart file ..\extract_chart_data.dart

They seem to be related to having \ in paths, which is then included in a URL, for example in the network tab I see (note the %5C):

http://127.0.0.1:61559/M:/Dev/Sites/extract_chart_data/lib/..%5Cextract_chart_data.dart?inline=true&authToken=axUG58VB3pc%3D

This happens when clicking one of the action buttons for a path that has backslashes in the displayed path:

I wasn't able to make this run from source on Windows to try making changes (it seems to fail to resolve package: paths), though I found this function that might be an appropriate place to handle converting the slashes when going from paths to URLs?

sdk/pkg/nnbd_migration/lib/src/front_end/region_renderer.dart

Lines 85 to 93 in f190a4a

	/// Returns the URL that will navigate to the given [target].
	String _relativePathToTarget(NavigationTarget target, String unitDir) {
	if (target == null) {
	// TODO(brianwilkerson) This is temporary support until we can get targets
	// for all nodes.
	return '';
	}
	return pathContext.relative(pathMapper.map(target.filePath), from: unitDir);
	}

[DanTup]

That said, this path looks like it may be incorrect even if you fix the slash:

M:/Dev/Sites/extract_chart_data/lib/..%5Cextract_chart_data.dart

Because extract_chart_data/lib/../extract_chart_data.dart would end up as extract_chart_data/extract_chart_data.dart and that's not correct (the file is inside lib).

[DanTup]

@srawlins This change seems to fix one of my issues on Windows (though unsure if it's the best place for it):

diff --git a/pkg/nnbd_migration/lib/src/front_end/region_renderer.dart b/pkg/nnbd_migration/lib/src/front_end/region_renderer.dart
index 2d97c61bbe..702965f83b 100644
--- a/pkg/nnbd_migration/lib/src/front_end/region_renderer.dart
+++ b/pkg/nnbd_migration/lib/src/front_end/region_renderer.dart
@@ -89,7 +89,9 @@ class RegionRenderer {
       //  for all nodes.
       return '';
     }
-    return pathContext.relative(pathMapper.map(target.filePath), from: unitDir);
+    return pathContext
+        .relative(pathMapper.map(target.filePath), from: unitDir)
+        .replaceAll(r'\', '/'); // Ensure all forwards slashes even on Windows.
   }

   /// Return the URL that will navigate to the given [target] in the file at the

(I also needed this for the generate scripts to work on Windows):

diff --git a/pkg/nnbd_migration/tool/codegen/generate_resources.dart b/pkg/nnbd_migration/tool/codegen/generate_resources.dart
index 18695ef2bc..e1a9c86e6a 100644
--- a/pkg/nnbd_migration/tool/codegen/generate_resources.dart
+++ b/pkg/nnbd_migration/tool/codegen/generate_resources.dart
@@ -90,7 +90,8 @@ String base64Encode(List<int> bytes) {

 void compileWebFrontEnd({bool devMode = false}) async {
   var sdkBinDir = path.dirname(Platform.resolvedExecutable);
-  var dart2jsPath = path.join(sdkBinDir, 'dart2js');
+  var dart2jsBinary = Platform.isWindows ? 'dart2js.bat' : 'dart2js';
+  var dart2jsPath = path.join(sdkBinDir, dart2jsBinary);

   // dart2js -m -o output source
   var process = await Process.start(dart2jsPath, [

However the other issue remains (and may be what the earlier comments here were hitting). If I click the button marked 2 here, it normally works.

However if I first click the link marked 1 (which opens that file on the left), and then click the button marked 2, then I get an error:

Could not add/remove hint

FileSystemException(path=M:\Dev\Sites\extract_chart_data\lib\data_table.dart; message=Cannot open file)

The path here is missing the "lib". It seems like opening another file may be affecting how the relative path is resolved for the actions in the right panel?

[srawlins]

@DanTup I've landed a fix for the original issue, which is not specific to Windows. The issue you are seeing may be specific to Windows.

I suspect they are different issues, but if you are able to build Dart at HEAD, could you try with my recent fixes (e7c79ae) and if you still see your issue, open a new issue? Thanks!

[DanTup]

@srawlins I can't build, but a nightly build was made an hour ago so I tested with that. I've filed #43178 with a repository and exact steps to reproduce.

[srawlins]

I'll close this one then.