Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Out of memory during background compilation should not be fatal #42852

Closed
rmacnak-google opened this issue Jul 27, 2020 · 0 comments
Closed

Out of memory during background compilation should not be fatal #42852

rmacnak-google opened this issue Jul 27, 2020 · 0 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. dartfuzz Found with Dart fuzzing (DartFuzz, libFuzzer, etc.)

Comments

@rmacnak-google
Copy link
Contributor

The background compilation should instead be aborted.

This is responsible for several fuzzer failures, and prevents effective use of the max heap size flags with the JIT.
@rmacnak-google rmacnak-google added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. dartfuzz Found with Dart fuzzing (DartFuzz, libFuzzer, etc.) labels Jul 27, 2020
dart-bot pushed a commit that referenced this issue Jul 28, 2020
@rmacnak-google
[vm] Fail gracefully when background compilation runs out of memory.
3a82163 
Bug: #42852
Change-Id: I63ba1cb71dd9ad50b583a19ea3a3859c1d667ccc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156042
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. dartfuzz Found with Dart fuzzing (DartFuzz, libFuzzer, etc.)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rmacnak-google