Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart2js should support --multi-root-scheme and --multi-root configuration #42932

Closed
jakemac53 opened this issue Aug 4, 2020 · 2 comments
Closed

dart2js should support --multi-root-scheme and --multi-root configuration #42932

jakemac53 opened this issue Aug 4, 2020 · 2 comments
Assignees
@jakemac53
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. web-dart2js

Comments

@jakemac53
Copy link
Contributor

Most other tools at this point have converged on this mechanism for supporting fake file system "root"(s) - this is useful for build systems in general that want hermetic output for actions.

Today it does support I think an undocumented "bazel-root" scheme that serves the same purpose, but it would be better to unify things (and make the scheme user-supplied).
@jakemac53 jakemac53 added the area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. label Aug 4, 2020
@jakemac53 jakemac53 mentioned this issue Aug 4, 2020
Merged
@jakemac53 jakemac53 self-assigned this Aug 6, 2020
@jakemac53
Copy link
Contributor Author

It looks like dart2js relies on a sync file system so I cannot use the shared impl, but it is easy enough to reproduce.

dart-bot pushed a commit that referenced this issue Aug 7, 2020
@jakemac53
Add multi root source provider for dart2js
b67d053 
Bug:#42932
Change-Id: I565b2900fca05d3b88fc24e4cfb46944ef1d4ae4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157475
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
@jakemac53
Copy link
Contributor Author

This is implemented now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakemac53 jakemac53

Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakemac53 @sigmundch