Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named optional parameter can begin with an underscore #434

Closed
DartBot opened this issue Nov 14, 2011 · 5 comments
Closed

Named optional parameter can begin with an underscore #434

DartBot opened this issue Nov 14, 2011 · 5 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.

Comments

@DartBot
Copy link

DartBot commented Nov 14, 2011

This issue was originally filed by alexei.kaigo...@gmail.com


Dart Language specification reads:
6.2.2 Named Optional Formals
 It is a compile-time error if the name of a named optional parameter begins with an _ character.

However, dart_bin reports no error in such cases.

What steps will reproduce the problem?

  1. create test file:
    main() {
      void func([var _x]) {}
    }
  2. run it with dart/out/Debug_ia32/dart_bin
  3. check returned error code

What is the expected output? What do you see instead?
compiler error expected, but no error reported

What version of the product are you using? On what operating system?
dart svn revision 1499, on Linux

Please provide any additional information below.:

This error causes failure of the test
co19/LangSpecTest/06_Functions/06_2_Formal_Parameters/06_2_2_Named_Optional_Formals/A03/t01

@DartBot
Copy link
Author

DartBot commented Nov 15, 2011

This comment was originally written by drfibonacci@google.com


Added Area-VM, Triaged labels.

@iposva-google
Copy link
Contributor

Set owner to @mhausner.
Added Accepted label.

@DartBot
Copy link
Author

DartBot commented Mar 13, 2012

This comment was originally written by @mhausner


Fixed at r5444.


Added Fixed label.

@ghost
Copy link

ghost commented Mar 16, 2012

The spec is under discussion, reopen the bug as a language issue.


Removed the owner.
Removed Area-VM label.
Added Area-Language, Triaged labels.

@ghost
Copy link

ghost commented Mar 16, 2012

Issue #1012 has been merged into this issue.


Set owner to @mhausner.
Removed Area-Language label.
Added Area-VM, Fixed labels.

@DartBot DartBot added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. labels Mar 16, 2012
copybara-service bot pushed a commit that referenced this issue Jun 2, 2022
Changes:
```
> git log --format="%C(auto) %h %s" 5699caf..e3f4bd2
 https://dart.googlesource.com/markdown.git/+/e3f4bd2 example: update CDN asset links (#435)
 https://dart.googlesource.com/markdown.git/+/a678bfc example: add GitHub markdown CSS (#434)
 https://dart.googlesource.com/markdown.git/+/bc79c43 Merge pull request #425 from dart-lang/pq-patch-1
 https://dart.googlesource.com/markdown.git/+/4e8aa03 add pub badge
 https://dart.googlesource.com/markdown.git/+/7987e1e Remove dependency on third party package:charcode.
 https://dart.googlesource.com/markdown.git/+/90995fd Split block_parser.dart and inline_parser.dart (#422)
 https://dart.googlesource.com/markdown.git/+/8bb9062 Add trailing commas to some parameter lists to get better formatting (#420)
 https://dart.googlesource.com/markdown.git/+/1c5f2e7 Enable raw strings lint rules (#418)
 https://dart.googlesource.com/markdown.git/+/4784153 Enable use_if_null_to_convert_nulls_to_bools lint rule (#417)
 https://dart.googlesource.com/markdown.git/+/0d67e99 Enable prefer_interpolation_to_compose_strings (#416)
 https://dart.googlesource.com/markdown.git/+/5561351 Enable prefer_final_locals lint rule (#415)
 https://dart.googlesource.com/markdown.git/+/6d39147 Create DelimiterSyntax to replace TagSyntax (#407)
 https://dart.googlesource.com/markdown.git/+/4f4e899 Add caseSensitive parameter on the InlineSyntax constructor (#400)
 https://dart.googlesource.com/markdown.git/+/e16aff0 Check parser.isDone when title is null in _parseInlineBracketedLink (#394)
 https://dart.googlesource.com/markdown.git/+/3471578 Use `Uri.toFilePath()` instead of `Uri.path` for locating tests (#396)

```

Diff: https://dart.googlesource.com/markdown.git/+/5699cafa9ef004875fd7de8ae9ea00e5295e87a4~..e3f4bd28c9e61b522f75f291d4d6cfcfeccd83ee/
Change-Id: Ie04b17dfcce57fcd9e814bd8b9a09677a91136d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246984
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.
Projects
None yet
Development

No branches or pull requests

2 participants