Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated hint is not reported when the deprecated formal parameter is in Null Safe library, and the use in in legacy #43929

Closed
scheglov opened this issue Oct 26, 2020 · 3 comments
Closed

Deprecated hint is not reported when the deprecated formal parameter is in Null Safe library, and the use in in legacy #43929

scheglov opened this issue Oct 26, 2020 · 3 comments
Assignees
@scheglov
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.

Comments

@scheglov
Copy link
Contributor

scheglov commented Oct 26, 2020 •
edited
Loading

I had to update DataDrivenFixProcessorTest.setPackageContent with language 2.9 to make test_cupertino_CupertinoTextThemeData_copyWith_deprecated in FlutterUseCaseTest to pass.

The change will probably land as https://dart-review.googlesource.com/c/sdk/+/169141

@bwilkerson this might be an issue for the actual Flutter migration.
@scheglov scheglov added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Oct 26, 2020
@bwilkerson
Copy link
Member

Yes, it probably will be.

That begs the question of why the hint isn't being reported; that feels like a bug, and I'd rather see the bug fixed than to have the test changed.

@scheglov
Copy link
Contributor Author

Yes, definitely the bug should be fixed, and the hint should be reported.
I just wanted for you to know that there is a problem, and put some record for whoever will fix it.

@scheglov scheglov self-assigned this Oct 28, 2020
@scheglov
Copy link
Contributor Author

https://dart-review.googlesource.com/c/sdk/+/169256

dart-bot pushed a commit that referenced this issue Oct 28, 2020
@scheglov
Issue 43929. Report HintCode.DEPRECATED_MEMBER_USE for Null Safe from…
1958d61 
… Legacy, refactoring.

Bug: #43929
Change-Id: Ib05f2e44f6cac2acfcb8b3708bd88e38df70d6c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/169256
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scheglov @bwilkerson