You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The info severity level has only been used in one instance before, and
that could only occur in the compile command.
https://dart-review.googlesource.com/c/sdk/+/180361 and
https://dart-review.googlesource.com/c/sdk/+/180560 introduced the first
uses of this severity level outside the compile command.
This is the first time an `info` is emitted in the frontend_server.
We don't want to emit `info`s for the server. This is a quick solution
to fix that. The solution has been manually verified with a Flutter app
run with a local engine build with this change patched in.
Bug: flutter/flutter#75429
Keeping the diff as small as possible to ease cherry pick for release.
The better solution is to make the frontend_server's verbosity level
configurable.
Bug: #44867
Change-Id: Ie40dbb27621053e90bc8943b8cb7c5ec4c9ed643
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/183005
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
The info severity level has only been used in one instance before, and
that could only occur in the compile command.
https://dart-review.googlesource.com/c/sdk/+/180361 and
https://dart-review.googlesource.com/c/sdk/+/180560 introduced the first
uses of this severity level outside the compile command.
This is the first time an `info` is emitted in the frontend_server.
We don't want to emit `info`s for the server. This is a quick solution
to fix that. The solution has been manually verified with a Flutter app
run with a local engine build with this change patched in.
Bug: flutter/flutter#75429
Keeping the diff as small as possible to ease cherry pick for release.
The better solution is to make the frontend_server's verbosity level
configurable.
Bug: #44867
Change-Id: Ie40dbb27621053e90bc8943b8cb7c5ec4c9ed643
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/183005
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
sdk/pkg/frontend_server/lib/frontend_server.dart
Lines 355 to 374 in 302de78
The frontend_server should have a verbosity level setting and use that while deciding to print things to the configured output stream.
Currently it also prints
Severity.info
, leading to flutter/flutter#75429.I'll make a CL to exclude
info
from prints, but the cleaner solution would be to support a verbosity level in the frontend_server.As discussed with @johnniwinther.
The text was updated successfully, but these errors were encountered: