Tool reports errors that are not user responsibility related to FFI

[dnfield]

Related to #75113

I talked a bit more with @dcharkes about this.

Package:ffi is getting updated, so other packages will be able to update. I'm still concerned that users will see a big wall of red text that they shouldn't when they depend on a non-upgraded package on the current release candidate.

For example, this program (using path_provider: 1.6.27, which in turn depends on win32 and ffi transitively):

import 'package:path_provider/path_provider.dart'

void main() {
  print('hello');
}

Will print out the string of warnings listed in #75113.

If the CFE reports these issues in a dependency, we should not print out the warnings, similar to how we do not print out deprecation warnings in other packages (we let the analyzer handle that).

/cc @dcharkes @jonahwilliams @christopherfujino

[dnfield]

In particular, we want to avoid users who are going to upgrade to the new release candidate and depend on any of a number of popular packages that depend no package:ffi/win32/etc from seeing a wall of red text whenever they run/test their app.

@dcharkes is going to provide the specific hint type the CFE is emitting.

[dcharkes]

Analyzer codes for deprecation messages: EMPTY_STRUCT_WARNING, NON_CONSTANT_TYPE_ARGUMENT_WARNING.

CFE identifiers: FfiEmptyStructWarning, FfiNonConstantTypeArgumentWarning.

[dnfield]

We talked offline some more - it'll probably be best to remove the hints from the CFE for this, @dcharkes is going to look into this

[dcharkes]

Turns out my CLs were the first to ever emit info-severity messages from the frontend_server. We've landed a change to no longer print infos in the frontend server and filed a CP on Dart (dart-lang/sdk#44869).

Thanks @johnniwinther for the background info and quick review!

[tvolkert]

@dcharkes is there anything still to do here, or are we just waiting for the CLs to roll through?

[dcharkes]

Do you need to do anything on your side to make the Dart beta roll into a new Flutter beta? If no, then we're done.

Dart beta with CP dart-lang/sdk@bc1fa17

[christopherfujino]

@tvolkert @pcsosinski sounds like with regards to the RC branch, the next release will pick up the dart fix and resolve this issue.

[pcsosinski]

removing cp label as this will be picked up with the Dart CP

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.