Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable new FixInFileProcessor #45026

Closed
pq opened this issue Feb 16, 2021 · 1 comment
Closed

enable new FixInFileProcessor #45026

pq opened this issue Feb 16, 2021 · 1 comment
Assignees
@pq
Labels
analyzer-bulk-fix analyzer-quick-fix area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on

Comments

@pq
Copy link
Member

pq commented Feb 16, 2021

Follow-up from https://dart-review.googlesource.com/c/sdk/+/185081.

Short-term we should disable the existing mechanism for producing fix all fixes and then enable the new processor.
@pq pq added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-quick-fix analyzer-bulk-fix labels Feb 16, 2021
@pq pq self-assigned this Feb 16, 2021
dart-bot pushed a commit that referenced this issue Feb 16, 2021
@pq
disable legacy fix-all fix creation
4302f05 
Tests to be re-enabled when we wire-up `FixInFileProcessor`.  (Or maybe we want a different approach to testing fix all fixes entirely?  TBD.)

See: #45026

Change-Id: I66f83d06801a71143dcc770cc38d9e2f86782264
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185180
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
@devoncarew devoncarew added the P2 A bug or feature request we're likely to work on label Feb 19, 2021
@pq
Copy link
Member Author

pq commented Mar 15, 2021

Enabled. 👍

@pq pq closed this as completed Mar 15, 2021
@asashour asashour mentioned this issue Sep 4, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
analyzer-bulk-fix analyzer-quick-fix area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pq @devoncarew