Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable DevTools for standalone VM #45867

Closed
bkonyi opened this issue Apr 29, 2021 · 5 comments
Closed

Add option to disable DevTools for standalone VM #45867

bkonyi opened this issue Apr 29, 2021 · 5 comments
Assignees
Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. dart-cli-run Issues related to 'dart run'

Comments

@bkonyi
Copy link
Contributor

bkonyi commented Apr 29, 2021

We should provide a --disable-devtools flag to allow for users to prevent DevTools from being served by DDS as some tools / IDEs currently serve their own instances.

@bkonyi bkonyi added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. dart-cli-run Issues related to 'dart run' labels Apr 29, 2021
@bkonyi bkonyi self-assigned this Apr 29, 2021
@jonahwilliams
Copy link
Contributor

I'm assuming that we're also not going to be starting devtools if we're passing --disable-dart-dev too? Or do we need to add a new flag to the flutter tool bootstrap and other parts of the tool?

@bkonyi
Copy link
Contributor Author

bkonyi commented Apr 29, 2021

Yes, that's the case. Also, DevTools will only start if --enable-vm-service or --observe is provided, so even if --disable-dart-dev isn't provided (aside: I'd like to drop that flag at some point since it won't impact startup time for basic runs like dart foo.dart) DevTools won't spawn unless the user explicitly enables the service.

@jonahwilliams
Copy link
Contributor

i believe the concern was less to do with startup time and more to do with making sure programming errors in the tool are surfaced correctly. for example dart program.dart where the program is missing should not print out a warning about there not being a program.dart command

@bkonyi
Copy link
Contributor Author

bkonyi commented Apr 29, 2021

i believe the concern was less to do with startup time and more to do with making sure programming errors in the tool are surfaced correctly. for example dart program.dart where the program is missing should not print out a warning about there not being a program.dart command

Oh, well if that's the case, that shouldn't be an issue anymore:

$ dart bad.dart
Error when reading 'bad.dart': No such file or directory.

@jonahwilliams
Copy link
Contributor

cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. dart-cli-run Issues related to 'dart run'
Projects
None yet
Development

No branches or pull requests

2 participants