-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FLAG_enable_testing_pragmas broken on *-precomp-win-* #46059
Comments
Tentatively triaging into area-vm |
I have verified that linking against Lines 1050 to 1052 in 28c784d
I've noticed that So the root cause appears to be #40579. |
This removes the need for passing the flag to use Dart_ExecuteInternalCommand, which is done in several tests that otherwise have nothing to do with testing pragmas. Also adds status file skips for precomp-win targets that currently crash due to #40579. TEST=CQ Bug: #46059, #46061 Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-win-release-x64-try,vm-kernel-precomp-nnbd-win-release-x64-try,vm-kernel-win-debug-x64-try Change-Id: I3024ad9bedb7a74abaaaa1020b7525e5d8b1bd47 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200461 Commit-Queue: Clement Skau <cskau@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
It appears that at least one
FLAG_..
is broken when running precompiled on Windows.An easy way to replicate this is by removing the
if(!FLAG_..) ..
check in runtime/vm/native_api_impl.cc.After which the following tests will fail:
vmspecific_regress_37511_test
vmspecific_regress_37511_callbacks_test
vmspecific_function_gc_test
vmspecific_function_callbacks_test
Importantly, removing the above line should not have any effect on these tests as they each explicitly set:
// VMOptions=--enable-testing-pragmas ...
Meaning the condition removed should always be a no-op.
It's quite possible this issue is related to #40579
The text was updated successfully, but these errors were encountered: