Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures on Discontinue dart2native (use dart compile) #46970

Closed
alexmarkov opened this issue Aug 23, 2021 · 1 comment
Closed

Failures on Discontinue dart2native (use dart compile) #46970

alexmarkov opened this issue Aug 23, 2021 · 1 comment
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening

Comments

@alexmarkov
Copy link
Contributor

There are new test failures on Discontinue dart2native (use dart compile).

The tests

pkg/vm_snapshot_analysis/test/precompiler_trace_test RuntimeError (expected Pass)

are failing on configurations

unittest-asserts-release-win

Log:

--- Command "vm" (took 05.000683s):
set DART_CONFIGURATION=ReleaseX64 & set DART_SUPPRESS_WER=1 & set CHROME_PATH=C:\b\s\w\ir\cache\builder\sdk\third_party\browsers\chrome\Chrome\Application\chrome.exe & out\ReleaseX64\dart-sdk\bin\dart.exe --enable_asserts --ignore-unrecognized-flags --packages=C:\b\s\w\ir\cache\builder\sdk\.packages C:\b\s\w\ir\cache\builder\sdk\pkg\vm_snapshot_analysis\test\precompiler_trace_test.dart

exit code:
255

stdout:
00:00 �[32m+0�[0m: precompiler-trace basic-parsing�[0m

00:00 �[32m+0�[0m�[31m -1�[0m: precompiler-trace basic-parsing �[1m�[31m[E]�[0m�[0m

  Failed to locate `dart` in the SDK

  pkg\vm_snapshot_analysis\test\utils.dart 16:5                   dartCompile.<fn>
  pkg\vm_snapshot_analysis\test\utils.dart 20:2                   dartCompile
  pkg\vm_snapshot_analysis\test\utils.dart                        dartCompile
  pkg\vm_snapshot_analysis\test\utils.dart 73:38                  withFlagImpl.<fn>
  ===== asynchronous gap ===========================
  pkg\vm_snapshot_analysis\test\utils.dart 101:5                  withTempDir
  ===== asynchronous gap ===========================
  pkg\vm_snapshot_analysis\test\precompiler_trace_test.dart 72:7  main.<fn>.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/declarer.dart 199:9                Declarer.test.<fn>.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/declarer.dart 197:7                Declarer.test.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/invoker.dart 257:7                 Invoker._waitForOutstandingCallbacks.<fn>
  

Consider enabling the flag chain-stack-traces to receive more detailed exceptions.
For example, 'dart test --chain-stack-traces'.
00:00 �[32m+0�[0m�[31m -1�[0m: precompiler-trace collapse-by-package�[0m

00:00 �[32m+0�[0m�[31m -2�[0m: precompiler-trace collapse-by-package �[1m�[31m[E]�[0m�[0m

  Failed to locate `dart` in the SDK

  pkg\vm_snapshot_analysis\test\utils.dart 16:5                    dartCompile.<fn>
  pkg\vm_snapshot_analysis\test\utils.dart 20:2                    dartCompile
  pkg\vm_snapshot_analysis\test\utils.dart                         dartCompile
  pkg\vm_snapshot_analysis\test\utils.dart 73:38                   withFlagImpl.<fn>
  ===== asynchronous gap ===========================
  pkg\vm_snapshot_analysis\test\utils.dart 101:5                   withTempDir
  ===== asynchronous gap ===========================
  pkg\vm_snapshot_analysis\test\precompiler_trace_test.dart 104:7  main.<fn>.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/declarer.dart 199:9                 Declarer.test.<fn>.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/declarer.dart 197:7                 Declarer.test.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/invoker.dart 257:7                  Invoker._waitForOutstandingCallbacks.<fn>
  

Consider enabling the flag chain-stack-traces to receive more detailed exceptions.
For example, 'dart test --chain-stack-traces'.
00:00 �[32m+0�[0m�[31m -2�[0m: �[31mSome tests failed.�[0m

stderr:
Unhandled exception:
Dummy exception to set exit code.

--- Re-run this test:
python3 tools/test.py -n unittest-asserts-release-win pkg/vm_snapshot_analysis/test/precompiler_trace_test

https://dart-ci.appspot.com/log/pkg-win-release/unittest-asserts-release-win/17553/pkg/vm_snapshot_analysis/test/precompiler_trace_test

/cc @mit-mit @sstrickl @bkonyi @devoncarew

@alexmarkov alexmarkov added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening labels Aug 23, 2021
@mit-mit
Copy link
Member

mit-mit commented Aug 24, 2021

I think I have a fix for this in https://dart-review.googlesource.com/c/sdk/+/211060

@mit-mit mit-mit self-assigned this Aug 24, 2021
dart-bot pushed a commit that referenced this issue Aug 24, 2021
TEST=Not applicable, fixing existing test

Change-Id: Ie39b7d71fdd1260471f44d98b0f75fe2d5a39153
Bug: #46970
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/211060
Commit-Queue: Michael Thomsen <mit@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
@mit-mit mit-mit closed this as completed Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening
Projects
None yet
Development

No branches or pull requests

2 participants