Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm/cc IR AOT tests run without FLAG_precompiled_mode set #47044

Open
rmacnak-google opened this issue Aug 30, 2021 · 0 comments
Open

vm/cc IR AOT tests run without FLAG_precompiled_mode set #47044

rmacnak-google opened this issue Aug 30, 2021 · 0 comments
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).

Comments

@rmacnak-google
Copy link
Contributor

Various parts of the compiler do different things based on this flag, so these tests aren't properly AOT mode.
@rmacnak-google rmacnak-google added the area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). label Aug 30, 2021
dart-bot pushed a commit that referenced this issue Aug 30, 2021
@rmacnak-google
[vm, compiler] Add missing deopt info to CheckNullInstr.
93d111d 
TEST=ci
Bug: #46790
Bug: #47044
Change-Id: I6f4fc095ddb7701c9b61434d85839cb6d5dccc1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208687
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rmacnak-google