Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kFpuRegisterSize should depend on target architecture, not host #47802

Closed
rmacnak-google opened this issue Nov 29, 2021 · 0 comments
Closed

kFpuRegisterSize should depend on target architecture, not host #47802

rmacnak-google opened this issue Nov 29, 2021 · 0 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@rmacnak-google
Copy link
Contributor

rmacnak-google commented Nov 29, 2021 •
edited
Loading

Currently kFpuRegisterSize is set in globals.h based on the host architecture. This works by accident because the current set of architectures all set it to 16. RISC-V should set it to 8, so we need to properly base it on the target architecture and move it to constants_.h.
@rmacnak-google rmacnak-google added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Nov 29, 2021
copybara-service bot pushed a commit that referenced this issue Jan 5, 2022
@rmacnak-google
[vm] Define kFpuRegisterSize based on the target architecture, not th…
0ec95bf 
…e host architecture.

TEST=ci
Bug: #47802
Change-Id: Icf4522df4109dd653727aa988ba4dccd8f939ae2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/226420
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rmacnak-google