Occurrences not working correctly for super parameters

[bwilkerson]

Given a file containing

class A {
  A(int x);
}

class B extends A {
  int y;

  B(super.x) : y = x * 2;

  B.x(this.y) : assert(y > 0), super(0);
}

If I select the reference to y in the assert, then that reference, the y in this.y, the y in y = x * 2, and the y in the field declaration are all highlighted. Basically, we've said that the this.y parameter and the field are the same, so any references to either one should all be highlighted at the same time.

On the other hand, if I select the x in super.x, then the field declaration (in A) is highlighted, but the x in x * 2 is not. I think that for consistency it needs to be.

[scheglov]

I believe that it already works in DAS, but I will add a test.
https://dart-review.googlesource.com/c/sdk/+/234223

I think it does not work because IntelliJ plugin does not support super-formal parameters yet.
I'm actually not sure if IntelliJ uses AnalysisService.OCCURRENCES.

@jwren

[asashour]

IntelliJ plugin doesn't use AnalysisService.occurrences, but uses navigation for calculating the reference highlighting.

This case works fine

class A {
  int x;
  int y;

  A(this.x) : y = x * 2;
}

because the x in x * 2 targets x in the declaration int x, and not this.x.

However, in the case of

class A {
  A(int x);
}

class B extends A {
  int y;

  B(super.x) : y = x * 2;
}

The x in x * 2 targets super.x, and the latter then targets int x.

I find that targeting int x in the first example, while targeting super.x in the second one is inconsistent, or it least should be cleared before continuing with the IntelliJ part.

[scheglov]

I agree that for field formal parameters (the first case) and super formal parameters (the second) navigation is inconsistent. I seems to me that for the super formal parameters it is more correct - x in x * 2 is a reference to the value passed to the constructor (where x is implicitly a final formal parameter). Similarly for the field formal parameter x in x * 2 does not read the field int x - it uses the formal parameter value (also implicitly final formal parameter).

[scheglov]

https://dart-review.googlesource.com/c/sdk/+/244863