Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures on [repo] improve the analysis of the tools/ directory #48423

Closed
whesse opened this issue Feb 17, 2022 · 4 comments
Closed

Failures on [repo] improve the analysis of the tools/ directory #48423

whesse opened this issue Feb 17, 2022 · 4 comments
Assignees
@devoncarew
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).

Comments

@whesse
Copy link
Contributor

whesse commented Feb 17, 2022

There are new test failures on [repo] improve the analysis of the tools/ directory.

The test

standalone/io/addlatexhash_test CompileTimeError (expected Pass)

is failing on configurations

dartdevk-checked-mac-release-chrome
dartk-strong-linux-debug-x64
dartk-strong-linux-release-x64
dartk-strong-mac-release-arm64

Log in strong mode is stderr:
tools/addlatexhash.dart:25:1: Error: A library can't opt out of null safety by default, when using sound null safety.
// @Dart = 2.9
^^^^^^^^^^^^^^
@whesse whesse added the area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). label Feb 17, 2022
@devoncarew
Copy link
Member

Thanks, I'll take a look.

@devoncarew
Copy link
Member

This CL might address it: https://dart-review.googlesource.com/c/sdk/+/233530.

It looks like tools/addlatexhash.dart is being imported by tests/standalone/io/addlatexhash_test.dart (though I'm not sure why).

https://github.com/dart-lang/sdk/blob/main/tests/standalone/io/addlatexhash_test.dart#L10

copybara-service bot pushed a commit that referenced this issue Feb 18, 2022
@devoncarew
opt tools/addlatexhash.dart into NNBD
e8cc13c 
Bug: #48423
Change-Id: I3b779a18a3b2350ff18fa179b4f8a995cf301e28
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233530
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
@devoncarew
Copy link
Member

@whesse - I'm having trouble determining if this did in fact address the failure. Do you mind checking?

@whesse
Copy link
Contributor Author

whesse commented Feb 18, 2022

It looks like it has, from the result feed:
https://dart-ci.firebaseapp.com/#showLatestFailures=false&test=standalone/io/addlatexhash_test

I think it only shows up as fixed on three configurations, because the others run on daily builders and haven't run yet.

@whesse whesse closed this as completed Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devoncarew devoncarew

Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@devoncarew @whesse