Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid false positives applying Google3 specific functionality to non-google3 specific bazel workspaces #49629

Closed
jacob314 opened this issue Aug 9, 2022 · 4 comments
Closed

Avoid false positives applying Google3 specific functionality to non-google3 specific bazel workspaces #49629

jacob314 opened this issue Aug 9, 2022 · 4 comments
Assignees
@scheglov
Labels
analyzer-package Issues related to package:analyzer area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P3 A lower priority bug or feature request

Comments

@jacob314
Copy link
Member

jacob314 commented Aug 9, 2022

Related issue: #49544
The cherry pick was fine to unblock but I think the right solution to this is to stop treating non-g3 BAZEL workspaces as BAZEL workspaces as we don't really support that case anyway.
To detect g3 bazel workspaces we should check for the magic
dart/config/ide/flutter.json
file like the Flutter IntellIJ support does.
See
https://github.com/flutter/flutter-intellij/blob/e6bb872cca41d5bcdaebc073c6c6882f3fc22633/flutter-idea/src/io/flutter/bazel/Workspace.java#L34
That should avoid false positives like this and keep our different tools consistent.
@jacob314 jacob314 added the analyzer-package Issues related to package:analyzer label Aug 9, 2022
@jacob314
Copy link
Member Author

jacob314 commented Aug 9, 2022

Fyi @scheglov

@lrhn lrhn added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Aug 9, 2022
@scheglov
Copy link
Contributor

Start https://dart-review.googlesource.com/c/sdk/+/254343

copybara-service bot pushed a commit that referenced this issue Aug 10, 2022
@scheglov
Rename Bazel to Blaze - files, classes, methods.
4306592 
No changes to implementation yet, we still look for both Blaze and Bazel.

Bug: #49629
Change-Id: Iaf1b1cc2c9a8cf28d8bbfb5541819a1f5c8a3de6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254343
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
@scheglov
Copy link
Contributor

Replacing the marker file: https://dart-review.googlesource.com/c/sdk/+/254480

@srawlins srawlins added the P3 A lower priority bug or feature request label Aug 10, 2022
copybara-service bot pushed a commit that referenced this issue Aug 10, 2022
@scheglov
Use different marker file to identifier Blaze workspace.
f3d9193 
Bug: #49629
Change-Id: I8f1496735373494745a79d502488a217e3c71223
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
@scheglov
Copy link
Contributor

https://dart-review.googlesource.com/c/sdk/+/255141

mraleph referenced this issue Aug 16, 2022
@scheglov
Replace more Bazel with Blaze, some simplifications.
4eb511d 
Change-Id: I096860e17ce56c2f602718f11706f24989c1f65b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255141
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
analyzer-package Issues related to package:analyzer area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P3 A lower priority bug or feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@srawlins @scheglov @jacob314 @lrhn