Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Double_hashCode assembly intrinsic #50265

Closed
aam opened this issue Oct 20, 2022 · 0 comments
Closed

Refactor Double_hashCode assembly intrinsic #50265

aam opened this issue Oct 20, 2022 · 0 comments
Assignees
@aam
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@aam
Copy link
Contributor

aam commented Oct 20, 2022

As a follow-up to fix for #48641, as suggested on https://dart-review.googlesource.com/c/sdk/+/258600/15..29/runtime/vm/compiler/asm_intrinsifier_arm64.cc#b1109, we should remove assembly intrinsic implementation of Double_hashCode.
@aam aam added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Oct 20, 2022
@aam aam self-assigned this Oct 20, 2022
@aam aam added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Nov 1, 2022
copybara-service bot pushed a commit that referenced this issue Nov 17, 2022
@aam
[vm] Replace Double_hashCode native method with graph intrinsic imple…
a83cfa0 
…mentation.

Bug: #50265
TEST=ci
Change-Id: Icae87ce3871bb44599e0f1fa19d8becb3a6fcdec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264240
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
@aam aam closed this as completed Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aam aam

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aam @a-siva