Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Patterns] Fix analyzer unit tests failing with the 'patterns' feature enabled #50502

Closed
scheglov opened this issue Nov 17, 2022 · 8 comments
Closed

[Patterns] Fix analyzer unit tests failing with the 'patterns' feature enabled #50502

scheglov opened this issue Nov 17, 2022 · 8 comments
Assignees
@scheglov
Labels
analyzer-technical-debt area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone
Dart 3 beta 3

Comments

@scheglov
Copy link
Contributor

For now, these tests use language version override @dart = 2.18.
@scheglov scheglov added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-technical-debt labels Nov 17, 2022
@scheglov scheglov self-assigned this Nov 17, 2022
@pq pq added the P2 A bug or feature request we're likely to work on label Nov 17, 2022
@scheglov
Copy link
Contributor Author

messages.yaml was updated to force language 2.18 for

CompileTimeErrorCode.BREAK_LABEL_ON_SWITCH_MEMBER
CompileTimeErrorCode.CASE_EXPRESSION_TYPE_IMPLEMENTS_EQUALS
CompileTimeErrorCode.CASE_EXPRESSION_TYPE_IS_NOT_SWITCH_EXPRESSION_SUBTYPE
CompileTimeErrorCode.NON_CONSTANT_CASE_EXPRESSION
CompileTimeErrorCode.NON_CONSTANT_CASE_EXPRESSION_FROM_DEFERRED_LIBRARY
CompileTimeErrorCode.SWITCH_CASE_COMPLETES_NORMALLY

We should triage these failures, some of them are bugs, and some require changes to the snippets.

@scheglov
Copy link
Contributor Author

This is part of the language features work, so I should have set it to P1.
Correcting now :-)

@scheglov scheglov added P1 A high priority bug; for example, a single project is unusable or has many test failures and removed P2 A bug or feature request we're likely to work on labels Nov 17, 2022
copybara-service bot pushed a commit that referenced this issue Nov 18, 2022
@scheglov
Enable 'patterns' feature by default in analyzer unit tests.
624afb9 
Fixes one of the large failures, and marks remaining with
#50502

Change-Id: I66abb7509b1a8b8c2167b80436b80b25c55715e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/270520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
@asashour asashour mentioned this issue Nov 18, 2022
Open
@bwilkerson
Copy link
Member

If the fix is to update the snippets to use not-yet-valid code, we probably don't want to update them until shortly before the language feature ships.

@stereotype441
Copy link
Member

Note: in CL Add parser support for patternAssignment I've added @dart = 2.18 to one additional test: AssignmentDriverResolutionTest.test_notLValue_parenthesized_simple.

copybara-service bot pushed a commit that referenced this issue Nov 29, 2022
@stereotype441
Add parser support for patternAssignment.
7b41b62 
Bug: #50035, #50502, #50575
Change-Id: Idd3bdcae7cbb95c6f2016bb5d3efc638867f52af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/272383
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
@srawlins srawlins modified the milestones: Dart 3 stable, Dart 3 beta 2 Nov 30, 2022
@mit-mit
Copy link
Member

mit-mit commented Feb 23, 2023

@scheglov is there more work here?

copybara-service bot pushed a commit that referenced this issue Feb 27, 2023
@scheglov
Issue 50502. Fix a couple of analyzer unit tests.
a4687a0 
Bug: #50502
Change-Id: I1299a4fadaffae9b319ca0db1d2629a27a4775b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/285702
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
@scheglov
Copy link
Contributor Author

Not much, all that remains should land with https://dart-review.googlesource.com/c/sdk/+/285082

@itsjustkevin
Copy link
Contributor

@scheglov the CL noted in your last comment is closed, is there another CL we are missing to close this out?

@scheglov
Copy link
Contributor Author

OK, there are no more tests that fail and marked with this issue.
So, we can close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
analyzer-technical-debt area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
Dart 3 beta 3
Development

No branches or pull requests
7 participants
@pq @srawlins @stereotype441 @scheglov @bwilkerson @itsjustkevin @mit-mit