Failures on CL: Enforce current library restrictions.

[lrhn]

There are new test failures on Enforce current library restrictions..

The tests

pkg/analysis_server/test/integration/analysis/get_hover_test RuntimeError (expected Pass)

are failing on configurations

analyzer-unittest-asserts-release-linux

I have no idea why. Error message is:

stdout:
00:00 �[32m+0�[0m: AnalysisGetHoverIntegrationTest | test_getHover�[0m

00:01 �[32m+0�[0m�[31m -1�[0m: AnalysisGetHoverIntegrationTest | test_getHover �[1m�[31m[E]�[0m�[0m

  Expected: match '.*'
    Actual: <null>
     Which: not an <Instance of 'String'>
  

  package:test_api/src/expect/expect.dart 134:31                           fail
  package:test_api/src/expect/expect.dart 129:3                            _expect
  package:test_api/src/expect/expect.dart 46:3                             expect
  pkg/analysis_server/test/integration/analysis/get_hover_test.dart 87:9   AnalysisGetHoverIntegrationTest.checkHover.<fn>
  dart:async/zone.dart 1406:47                                             _rootRunUnary
  dart:async/zone.dart 1307:19                                             _CustomZone.runUnary
  ===== asynchronous gap ===========================
  pkg/analysis_server/test/integration/analysis/get_hover_test.dart 155:5  AnalysisGetHoverIntegrationTest.test_getHover
  ===== asynchronous gap ===========================
  package:test_api/src/backend/declarer.dart 215:9                         Declarer.test.<fn>.<fn>
  ===== asynchronous gap ===========================
  package:test_api/src/backend/declarer.dart 213:7                         Declarer.test.<fn>
  ===== asynchronous gap ===========================

[bwilkerson]

The line that's failing is testing to ensure that the doc comment for the class num is returned to the client (without depending on the actual content of the comment).

My unsubstantiated guess is that the test isn't enabling the sealed experiment and that the parser is recovering by assuming that sealed is a top-level variable, thus leaving the class declaration without a doc comment.

@scheglov Is there any reason why the integration tests shouldn't enable all of the accepted language experiments?

[lrhn]

The CL also enables the experiments for the platform libraries, so whatever the integration test does, it should probably honor the same enablings.

[scheglov]

I believe the issue is with the parser, we get wrong begin token to scrape documentation comments from.

[scheglov]

https://dart-review.googlesource.com/c/sdk/+/284441