Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[analyzer] Implement constant equality as primitive equality #51567

Closed
eernstg opened this issue Feb 28, 2023 · 3 comments
Closed

[analyzer] Implement constant equality as primitive equality #51567

eernstg opened this issue Feb 28, 2023 · 3 comments
Assignees
@scheglov
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on

Comments

@eernstg
Copy link
Member

eernstg commented Feb 28, 2023

This is the analyzer specific issue corresponding to #51565, which has the details.
@eernstg eernstg added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Feb 28, 2023
@eernstg eernstg mentioned this issue Feb 28, 2023
Closed
@eernstg
Copy link
Member Author

eernstg commented Feb 28, 2023

@scheglov, will this fit into Beta 3?

@scheglov
Copy link
Contributor

Yes, it should fit.
I suppose the change also happens only when the patterns feature it enabled?

@eernstg
Copy link
Member Author

eernstg commented Feb 28, 2023

Sounds good, thanks! Yes, enabling it as part of the patterns feature sounds fine!

@pq pq added the P2 A bug or feature request we're likely to work on label Feb 28, 2023
@scheglov scheglov self-assigned this Feb 28, 2023
copybara-service bot pushed a commit that referenced this issue Mar 1, 2023
@scheglov
Issue 51567. Implement constant equality as primitive equality
ad15774 
Bug: #51567
Change-Id: I7821598a761573519205b0ea06b13f433639282b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286241
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
@scheglov scheglov closed this as completed Mar 2, 2023
@pq pq mentioned this issue Mar 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pq @scheglov @eernstg