Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment references not resolving for super params #51578

Closed
pq opened this issue Feb 28, 2023 · 2 comments
Closed

comment references not resolving for super params #51578

pq opened this issue Feb 28, 2023 · 2 comments
Labels
analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P1 A high priority bug; for example, a single project is unusable or has many test failures P2 A bug or feature request we're likely to work on

Comments

@pq
Copy link
Member

pq commented Feb 28, 2023

See: dart-lang/linter#3563.

The comment_references lint fires on p1 but not p2.

class G {
  G({required int p1});
}

class H extends G {
  /// [p1] is better than [p2].
  H({required super.p1, required int p2});
}

Marking as P2 since this is discouraging folks from using super parameters (and blocking the adoption of the use_super_parameters lint).

@pq pq added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-linter Issues with the analyzer's support for the linter package P2 A bug or feature request we're likely to work on labels Feb 28, 2023
copybara-service bot pushed a commit that referenced this issue Feb 28, 2023
See: #51578

Change-Id: Icf000e008f5e04f6ab948b2d226877efa19bfd1a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286080
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
@pq
Copy link
Member Author

pq commented Sep 19, 2023

As @parlough points in dart-lang/lints#75 (comment), this is worth prioritizing as use_super_parameters is about to get a lot more use.

@pq pq added P1 A high priority bug; for example, a single project is unusable or has many test failures and removed P2 A bug or feature request we're likely to work on labels Sep 19, 2023
@srawlins
Copy link
Member

This is not a P1. As per our triage guidelines it is P2.

@srawlins srawlins added the P2 A bug or feature request we're likely to work on label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-linter Issues with the analyzer's support for the linter package area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P1 A high priority bug; for example, a single project is unusable or has many test failures P2 A bug or feature request we're likely to work on
Projects
None yet
Development

No branches or pull requests

2 participants