pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_ddc_sound_test flaky -> Timeout

[alexmarkov]

There are new test failures on [dart2js] Remove test configs that are now unused.

The tests

pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_ddc_sound_test Timeout (expected Pass)

are failing on configurations

unittest-asserts-release-win

Log: https://dart-ci.appspot.com/log/pkg-win-release/unittest-asserts-release-win/24068/pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_ddc_sound_test

Similar to #45713.

/cc @Markzipan

[Markzipan]

Our bots have a timeout of ~240s (4 min), so our newly added tests have likely pushed us just beyond this limit. I'll look at a smarter way of writing these kinds of tests of avoid this blow-up.

[alexmarkov]

Similarly, pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_ddc_unsound_test turned from flaky to Timeout.

Log: https://dart-ci.appspot.com/log/pkg-win-release/unittest-asserts-release-win/24077/pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_ddc_unsound_test

[alexmarkov]

pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_amd_unsound_test turned from flaky to Timeout on unittest-asserts-debug-linux configuration (pkg-linux-debug bot).

https://dart-ci.appspot.com/log/pkg-linux-debug/unittest-asserts-debug-linux/16791/pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_amd_unsound_test

[dcharkes]

I have also approved the timeout on https://dart-ci.appspot.com/log/pkg-linux-debug/unittest-asserts-debug-linux/16819/pkg/dev_compiler/test/expression_compiler/expression_compiler_e2e_ddc_sound_test

[sigmundch]

Just to keep everyone updated: the plan is to split the test in pieces, @nshahan has https://dart-review.googlesource.com/c/sdk/+/293384 in progress to do so.

[nshahan]

My change has landed and ideally this fixes all the flakes. Wouldn't that be great!

Realistically we probably still have flaky code in these tests that needs to be identified and fixed but I hope that now that they have been sharded the individual test timeouts will prevent the entire suite from timing out and getting killed by the infra. Then maybe we will find better clues to what is failing in the logs.

Since the test in this issue is now obsolete I'm going to close this and we can open a new issue if we start seeing new failures or flakes in the new suites.