Navigation from PatternField in IntelliJ

[scheglov]

class A {
  int get foo => 0;
}

void f(Object? x) {
  if (x case A(foo: var a)) {}
}

DAS produces the navigation region, see {"offset"::68,"length"::4,"targets"::[1]}] below:

1679348233072:Noti:{"event"::"analysis.highlights","params"::{"file"::"/Users/scheglov/dart/test/bin/test.dart","regions"::[{"type"::"KEYWORD","offset"::0,"length"::5},{"type"::"CLASS","offset"::6,"length"::1},{"type"::"BUILT_IN","offset"::16,"length"::3},{"type"::"INSTANCE_GETTER_DECLARATION","offset"::20,"length"::3},{"type"::"CLASS","offset"::12,"length"::3},{"type"::"LITERAL_INTEGER","offset"::27,"length"::1},{"type"::"TOP_LEVEL_FUNCTION_DECLARATION","offset"::38,"length"::1},{"type"::"KEYWORD","offset"::33,"length"::4},{"type"::"PARAMETER_DECLARATION","offset"::48,"length"::1},{"type"::"CLASS","offset"::40,"length"::6},{"type"::"KEYWORD","offset"::55,"length"::2},{"type"::"PARAMETER_REFERENCE","offset"::59,"length"::1},{"type"::"KEYWORD","offset"::61,"length"::4},{"type"::"CLASS","offset"::66,"length"::1},{"type"::"INSTANCE_GETTER_REFERENCE","offset"::68,"length"::3},{"type"::"KEYWORD","offset"::73,"length"::3},{"type"::"LOCAL_VARIABLE_DECLARATION","offset"::77,"length"::1}]}}
1679348233073:Noti:{"event"::"analysis.navigation","params"::{"file"::"/Users/scheglov/dart/test/bin/test.dart","regions"::[{"offset"::6,"length"::1,"targets"::[0]},{"offset"::12,"length"::3,"targets"::[2]},{"offset"::20,"length"::3,"targets"::[1]},{"offset"::38,"length"::1,"targets"::[3]},{"offset"::40,"length"::6,"targets"::[5]},{"offset"::48,"length"::1,"targets"::[4]},{"offset"::59,"length"::1,"targets"::[4]},{"offset"::66,"length"::1,"targets"::[0]},{"offset"::68,"length"::4,"targets"::[1]}],"targets"::[{"kind"::"CLASS","fileIndex"::0,"offset"::6,"length"::1,"startLine"::1,"startColumn"::7},{"kind"::"GETTER","fileIndex"::0,"offset"::20,"length"::3,"startLine"::2,"startColumn"::11},{"kind"::"CLASS","fileIndex"::1,"offset"::1286,"length"::3,"startLine"::28,"startColumn"::22},{"kind"::"FUNCTION","fileIndex"::0,"offset"::38,"length"::1,"startLine"::5,"startColumn"::6},{"kind"::"PARAMETER","fileIndex"::0,"offset"::48,"length"::1,"startLine"::5,"startColumn"::16},{"kind"::"CLASS","fileIndex"::2,"offset"::867,"length"::6,"startLine"::18,"startColumn"::7}],"files"::["/Users/scheglov/dart/test/bin/test.dart","/Users/scheglov/Source/Dart/sdk.git/sdk/xcodebuild/ReleaseARM64/dart-sdk/lib/core/int.dart","/Users/scheglov/Source/Dart/sdk.git/sdk/xcodebuild/ReleaseARM64/dart-sdk/lib/core/object.dart"]}}

But in IntelliJ it navigates back to foo: instead of the get foo declaration.

This requires https://dart-review.googlesource.com/c/sdk/+/289921 to be landed.

[scheglov]

@jwren

[jacob314]

@scheglov can you verify that the issue has now been fixed?

[scheglov]

Yes, I can navigate from foo: to get foo.