Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures on "[vm, gc] Add flag to disable write barrier elimination." #52990

Closed
bkonyi opened this issue Jul 19, 2023 · 0 comments
Closed

Failures on "[vm, gc] Add flag to disable write barrier elimination." #52990

bkonyi opened this issue Jul 19, 2023 · 0 comments
Assignees
@rmacnak-google
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening

Comments

@bkonyi
Copy link
Contributor

bkonyi commented Jul 19, 2023

vm/dart/gc/chunked_binary_trees_array_test/1, introduced in d486c52, has gone from flaky to Timeout. This test was marked as flaky when it was first submitted.

The tests

vm/dart/gc/chunked_binary_trees_array_test/1 Timeout (expected Pass)

are failing on configurations

vm-win-debug-x64

Logs:

--- Command "vm" (took 02:00.000517s):
set DART_CONFIGURATION=DebugX64 & set DART_SUPPRESS_WER=1 & set DART_CRASHPAD_HANDLER=C:\b\s\w\ir\out\DebugX64\crashpad_handler.exe & out\DebugX64\dart.exe --verify_store_buffer --sound-null-safety -Dtest_runner.configuration=vm-win-debug-x64 --ignore-unrecognized-flags --packages=C:\b\s\w\ir\.dart_tool\package_config.json C:\b\s\w\ir\runtime\tests\vm\dart\gc\chunked_binary_trees_array_test.dart

exit code:
1

diagnostics:
win_sdk_path not found

--- Re-run this test:
python3 tools/test.py -n vm-win-debug-x64 --previous-results LATEST/results.json vm/dart/gc/chunked_binary_trees_array_test/1
@bkonyi bkonyi added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening labels Jul 19, 2023
copybara-service bot pushed a commit that referenced this issue Aug 11, 2023
@rmacnak-google
[vm, gc] Remove flag to disable write barrier elimination.
f763d12 
 - This causes inconsistency between AppJIT trained kernel service including eliminating barriers but the runtime compensation being disabled.
 - The barrier elimination in the SuspendState stubs cannot be disabled.

TEST=ci
Bug: #52990
Change-Id: I4c5c7817a51f303d6f3bdbea8c15ad23a3e57735
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/319906
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmacnak-google rmacnak-google

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rmacnak-google @bkonyi