Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtin.dart's stdin has wrong variable type #536

Closed
DartBot opened this issue Nov 19, 2011 · 2 comments
Closed

builtin.dart's stdin has wrong variable type #536

DartBot opened this issue Nov 19, 2011 · 2 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.

Comments

@DartBot
Copy link

DartBot commented Nov 19, 2011

This issue was originally filed by joaope...@gmail.com


What steps will reproduce the problem?

  1. Try to run a file with the DartVM in checked mode while calling the "stdin" method.
  2. Like so: dart --enable-type-checks stdin_test.dart
  3. With this file content:
    main() {
      var any = stdin;
    }

What is the expected output? What do you see instead?

Expect no error. But get this:

Unhandled exception:
Failed type check: type SocketInputStream is not assignable to type OutputStream of function result in dart:builtin at line 26, column 28.
 0. Function: '::.get:stdin' url: 'dart:builtin' line:26 col:28
 1. Function: '::.main' url: '/home/dewd/t_/stdin_test.dart' line:3 col:13

What version of the product are you using? On what operating system?

Bleeding-edge Dart. Linux manga 3.0.0-12-generic-pae #­20-Ubuntu SMP Fri Oct 7 16:37:17 UTC 2011 i686 i686 i386 GNU/Linux

Please provide any additional information below.

Follows a patch.


Attachment:
patch_builtin.txt (370 Bytes)

@iposva-google
Copy link
Contributor

Please make sure that you add test coverage for these. The harness will run them both in checked and production mode.


cc @madsager.
Set owner to @sgjesse.
Added Area-VM, Accepted labels.

@sgjesse
Copy link
Contributor

sgjesse commented Nov 23, 2011

Fixed in https://code.google.com/p/dart/source/detail?r=1793.


Added Fixed label.

@DartBot DartBot added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. labels Nov 23, 2011
copybara-service bot pushed a commit that referenced this issue May 20, 2022
Changes:
```
> git log --format="%C(auto) %h %s" c1eb6cb..b149f80
 https://dart.googlesource.com/protobuf.git/+/b149f80 Remove the top level analysis_options.yaml file (#656)
 https://dart.googlesource.com/protobuf.git/+/8f6f307 Fix comment syntax
 https://dart.googlesource.com/protobuf.git/+/665f7b0 Remove trailing whitespace in protobuf/LICENSE
 https://dart.googlesource.com/protobuf.git/+/9ffbaf2 Fix default list type for frozen messages (#654)
 https://dart.googlesource.com/protobuf.git/+/a68bb5a Fix Fixed32 to be parsed as unsigned when parsing proto3 protos (#655)
 https://dart.googlesource.com/protobuf.git/+/6957c98 Convert the field started with underscore and digit to a legal name (#651)
 https://dart.googlesource.com/protobuf.git/+/71defca Account for double.infinity and double.nan in json serializers (#652)
 https://dart.googlesource.com/protobuf.git/+/5a48349 Allow `Timestamp.toDateTime()` to return a `DateTime` in local timezone (#653)
 https://dart.googlesource.com/protobuf.git/+/117e869 Make the toString of enums be the value if names are omitted (#649)
 https://dart.googlesource.com/protobuf.git/+/88c4016 Align the hashCode of a message with an empty unknown field-set with that of no unknown field set (#648)
 https://dart.googlesource.com/protobuf.git/+/eed09c4 Fix proto3 repeated field encoding without packed option (#635)
 https://dart.googlesource.com/protobuf.git/+/8f587b1 Simplify `_FieldSet` getters (#646)
 https://dart.googlesource.com/protobuf.git/+/494f189 Fix compile-protos.sh interpreter (#645)
 https://dart.googlesource.com/protobuf.git/+/5e1a422 Fix typo in protobuf-0.9.0+1 changelog
 https://dart.googlesource.com/protobuf.git/+/46df68a Add `UseResult` annotation to `rebuild` (#631)
 https://dart.googlesource.com/protobuf.git/+/ff5304f Migrate protoc_plugin to null safety (#642)
 https://dart.googlesource.com/protobuf.git/+/657197d Fix typo in GeneratedMessage.copyWith documentation (#641)
 https://dart.googlesource.com/protobuf.git/+/e30a522 Fix sharing coded buffer bytes when parsing `bytes` fields (#640)
 https://dart.googlesource.com/protobuf.git/+/810b166 Clear unknown field when setting an extension field with the same tag (#639)
 https://dart.googlesource.com/protobuf.git/+/d30623b Treat empty and uninitialized Maps the same in equality checks (#638)
 https://dart.googlesource.com/protobuf.git/+/4fe3ee4 Make `MapFieldInfo` key and value types non-nullable (#600)
 https://dart.googlesource.com/protobuf.git/+/c26ac34 Add grpc example to protoc_plugin README (#514)
 https://dart.googlesource.com/protobuf.git/+/c35d787 Revert changes to reserved names to maintain backwards compat (#636)
 https://dart.googlesource.com/protobuf.git/+/146b186 Remove unused `GeneratedMessage` constructors (#634)
 https://dart.googlesource.com/protobuf.git/+/1b12ac9 Remove a closure in `_FieldSet.hashCode` (#633)
 https://dart.googlesource.com/protobuf.git/+/5731242 Minor fix in query_bench set_nested_value benchmark: (#630)
 https://dart.googlesource.com/protobuf.git/+/767ce81 Remove fold() closures from `FieldSet._hashCode`. (#554)
 https://dart.googlesource.com/protobuf.git/+/99bc541 protoc_plugin README fixes and tweaks: (#617)
 https://dart.googlesource.com/protobuf.git/+/e282e17 protobuf benchs: invoke protoc once with all protos (#623)
 https://dart.googlesource.com/protobuf.git/+/bef672b protobuf benchs: fix old --trust-type-annotations flag (#622)
 https://dart.googlesource.com/protobuf.git/+/d072e5f dependabot: check for updates monthly (#620)
 https://dart.googlesource.com/protobuf.git/+/96bdf38 Fix TypeRegistry passing when unpacking nested Any messages from JSON (#568)
 https://dart.googlesource.com/protobuf.git/+/4ec722a Correctly combine hash codes for repeated enums. (#556)
 https://dart.googlesource.com/protobuf.git/+/b96dc21 Testing: don't return static methods in findMemberNames (#618)
 https://dart.googlesource.com/protobuf.git/+/09e8a8d Update protobuf/benchmarks README for #553
 https://dart.googlesource.com/protobuf.git/+/3ef4539 Add a benchmark for computing hashCodes. (#553)
 https://dart.googlesource.com/protobuf.git/+/d232e6e Tweak READMEs: (#610)
 https://dart.googlesource.com/protobuf.git/+/0f01fa9 Update protobuf pubspec.yaml (#616)
 https://dart.googlesource.com/protobuf.git/+/a10426b Update protoc_plugin pubspec.yaml (#615)
 https://dart.googlesource.com/protobuf.git/+/a0021c7 Make `protoName` unCamelCase lazy (#606)
 https://dart.googlesource.com/protobuf.git/+/ded1ac7 Document map key and value fields (#603)
 https://dart.googlesource.com/protobuf.git/+/8792f2a Remove redundant check in PbMap equality check (#604)
 https://dart.googlesource.com/protobuf.git/+/b7f9569 Tweak BuilderInfo and FieldInfo docs: (#597)
 https://dart.googlesource.com/protobuf.git/+/6f85c32 Remove a redundant cast (#598)
 https://dart.googlesource.com/protobuf.git/+/3df8669 Latest mono_repo (#601)
 https://dart.googlesource.com/protobuf.git/+/9da84ae Fix a potential issue in CodedBufferWriter (#594)
 https://dart.googlesource.com/protobuf.git/+/6be405f Remove old and unused test file (#589)
 https://dart.googlesource.com/protobuf.git/+/900cef5 Fix protoc_plugin run-tests make rule (#586)
 https://dart.googlesource.com/protobuf.git/+/2546269 Fix rounding when handling negative timestamps (#580)
 https://dart.googlesource.com/protobuf.git/+/8afce8d Fix Readme `pub get` instead of `pub install`. (#486)
 https://dart.googlesource.com/protobuf.git/+/782fd24 Avoid runtime function type check in lazily created singleton creator functions (#574)
 https://dart.googlesource.com/protobuf.git/+/a7e75cb Update README.md
 https://dart.googlesource.com/protobuf.git/+/23136dc Version bump (#563)
 https://dart.googlesource.com/protobuf.git/+/18346f5 Convert null keys and values to default when parsing map entries (#536)
 https://dart.googlesource.com/protobuf.git/+/bb4cf0b Bump to latest mono_repo - use latest actions (#561)
 https://dart.googlesource.com/protobuf.git/+/835ab75 Remove unneeded imports
 https://dart.googlesource.com/protobuf.git/+/ef733ac latest mono_repo
 https://dart.googlesource.com/protobuf.git/+/ecfb862 Fix test for latest analysis (#543)
 https://dart.googlesource.com/protobuf.git/+/26a0a26 fix insecure link in protoc_plugin readme
 https://dart.googlesource.com/protobuf.git/+/444e855 Bump dart-lang/setup-dart from 1.1 to 1.2 (#535)
 https://dart.googlesource.com/protobuf.git/+/d3e0e4a Fix analysis options
 https://dart.googlesource.com/protobuf.git/+/cf29280 Fix comment references

```

Diff: https://dart.googlesource.com/protobuf.git/+/c1eb6cb51af39ccbaa1a8e19349546586a5c8e31~..b149f801cf7a5e959cf1dbf72d61068ac275f24b/

Tested: relying on existing SDK and protobuf tests
Change-Id: I7f89b998a0aba13999d180ee9814a26a5f1d054d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245228
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ömer Ağacan <omersa@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
copybara-service bot pushed a commit that referenced this issue May 1, 2023
…, tools, watcher

Revisions updated by `dart tools/rev_sdk_deps.dart`.

ffi (https://github.com/dart-lang/ffi/compare/04fa38a..6d8fa8d):
  6d8fa8d  2023-05-01  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#191)

lints (https://github.com/dart-lang/lints/compare/f09399a..ba7d75e):
  ba7d75e  2023-04-26  Phil Quitslund  2.1.0 (#107)
  e6b82b6  2023-04-26  Devon Carew  Update lint-propoposal.md (#115)

markdown (https://github.com/dart-lang/markdown/compare/5f98aea..82b050d):
  82b050d  2023-04-30  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#536)

matcher (https://github.com/dart-lang/matcher/compare/cb6b68c..7228c26):
  7228c26  2023-04-27  dependabot[bot]  Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#215)

mockito (https://github.com/dart-lang/mockito/compare/f851e17..beb45ba):
  beb45ba  2023-04-26  yanok  Remove unused local variable
  d2e155f  2023-04-26  yanok  Require Dart SDK >= 2.19
  b777874  2023-04-26  yanok  First part of Dart3 support in Mockito
  ad3c9ae  2023-04-26  yanok  Fix the type variable capture problem
  6c448b2  2023-04-25  oprypin  Keep generated mock files at language version 2.19
  06f353e  2023-04-13  nbosch  Deprecate the mixingIn argument to MockSpec
  f3ecdad  2023-04-11  oprypin  Fix violations of `prefer_final_locals`, `prefer_final_in_for_each` lints

test (https://github.com/dart-lang/test/compare/c9a3138..b252463):
  b252463a  2023-05-01  dependabot[bot]  Bump github/codeql-action from 2.2.9 to 2.3.2 (#2001)

test_process (https://github.com/dart-lang/test_process/compare/946bc27..89c4fdc):
  89c4fdc  2023-05-01  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#42)

tools (https://github.com/dart-lang/tools/compare/5c9f45c..516995e):
  516995e  2023-04-28  Danny Tuppeny  Change "plugins" to "extensions" for VS Code (#75)

watcher (https://github.com/dart-lang/watcher/compare/00aa79b..6c0c838):
  6c0c838  2023-05-01  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#144)

Change-Id: I36d0db7f41a26e3f1430b86eff5d63b8e65c1616
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/300321
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.
Projects
None yet
Development

No branches or pull requests

3 participants