Spec chapter 8 (Interfaces) issues #574
Assignees
Labels
area-language
Dart language related items (some items might be better tracked at github.com/dart-lang/language).
Comments
|
This comment was originally written by drfibonacci@google.com Added Area-Language, Triaged labels. |
|
DartBot
added
Type-Defect
area-language
copybara-service bot
pushed a commit
that referenced
this issue
May 20, 2022
Changes: ``` > git log --format="%C(auto) %h %s" c1eb6cb..b149f80 https://dart.googlesource.com/protobuf.git/+/b149f80 Remove the top level analysis_options.yaml file (#656) https://dart.googlesource.com/protobuf.git/+/8f6f307 Fix comment syntax https://dart.googlesource.com/protobuf.git/+/665f7b0 Remove trailing whitespace in protobuf/LICENSE https://dart.googlesource.com/protobuf.git/+/9ffbaf2 Fix default list type for frozen messages (#654) https://dart.googlesource.com/protobuf.git/+/a68bb5a Fix Fixed32 to be parsed as unsigned when parsing proto3 protos (#655) https://dart.googlesource.com/protobuf.git/+/6957c98 Convert the field started with underscore and digit to a legal name (#651) https://dart.googlesource.com/protobuf.git/+/71defca Account for double.infinity and double.nan in json serializers (#652) https://dart.googlesource.com/protobuf.git/+/5a48349 Allow `Timestamp.toDateTime()` to return a `DateTime` in local timezone (#653) https://dart.googlesource.com/protobuf.git/+/117e869 Make the toString of enums be the value if names are omitted (#649) https://dart.googlesource.com/protobuf.git/+/88c4016 Align the hashCode of a message with an empty unknown field-set with that of no unknown field set (#648) https://dart.googlesource.com/protobuf.git/+/eed09c4 Fix proto3 repeated field encoding without packed option (#635) https://dart.googlesource.com/protobuf.git/+/8f587b1 Simplify `_FieldSet` getters (#646) https://dart.googlesource.com/protobuf.git/+/494f189 Fix compile-protos.sh interpreter (#645) https://dart.googlesource.com/protobuf.git/+/5e1a422 Fix typo in protobuf-0.9.0+1 changelog https://dart.googlesource.com/protobuf.git/+/46df68a Add `UseResult` annotation to `rebuild` (#631) https://dart.googlesource.com/protobuf.git/+/ff5304f Migrate protoc_plugin to null safety (#642) https://dart.googlesource.com/protobuf.git/+/657197d Fix typo in GeneratedMessage.copyWith documentation (#641) https://dart.googlesource.com/protobuf.git/+/e30a522 Fix sharing coded buffer bytes when parsing `bytes` fields (#640) https://dart.googlesource.com/protobuf.git/+/810b166 Clear unknown field when setting an extension field with the same tag (#639) https://dart.googlesource.com/protobuf.git/+/d30623b Treat empty and uninitialized Maps the same in equality checks (#638) https://dart.googlesource.com/protobuf.git/+/4fe3ee4 Make `MapFieldInfo` key and value types non-nullable (#600) https://dart.googlesource.com/protobuf.git/+/c26ac34 Add grpc example to protoc_plugin README (#514) https://dart.googlesource.com/protobuf.git/+/c35d787 Revert changes to reserved names to maintain backwards compat (#636) https://dart.googlesource.com/protobuf.git/+/146b186 Remove unused `GeneratedMessage` constructors (#634) https://dart.googlesource.com/protobuf.git/+/1b12ac9 Remove a closure in `_FieldSet.hashCode` (#633) https://dart.googlesource.com/protobuf.git/+/5731242 Minor fix in query_bench set_nested_value benchmark: (#630) https://dart.googlesource.com/protobuf.git/+/767ce81 Remove fold() closures from `FieldSet._hashCode`. (#554) https://dart.googlesource.com/protobuf.git/+/99bc541 protoc_plugin README fixes and tweaks: (#617) https://dart.googlesource.com/protobuf.git/+/e282e17 protobuf benchs: invoke protoc once with all protos (#623) https://dart.googlesource.com/protobuf.git/+/bef672b protobuf benchs: fix old --trust-type-annotations flag (#622) https://dart.googlesource.com/protobuf.git/+/d072e5f dependabot: check for updates monthly (#620) https://dart.googlesource.com/protobuf.git/+/96bdf38 Fix TypeRegistry passing when unpacking nested Any messages from JSON (#568) https://dart.googlesource.com/protobuf.git/+/4ec722a Correctly combine hash codes for repeated enums. (#556) https://dart.googlesource.com/protobuf.git/+/b96dc21 Testing: don't return static methods in findMemberNames (#618) https://dart.googlesource.com/protobuf.git/+/09e8a8d Update protobuf/benchmarks README for #553 https://dart.googlesource.com/protobuf.git/+/3ef4539 Add a benchmark for computing hashCodes. (#553) https://dart.googlesource.com/protobuf.git/+/d232e6e Tweak READMEs: (#610) https://dart.googlesource.com/protobuf.git/+/0f01fa9 Update protobuf pubspec.yaml (#616) https://dart.googlesource.com/protobuf.git/+/a10426b Update protoc_plugin pubspec.yaml (#615) https://dart.googlesource.com/protobuf.git/+/a0021c7 Make `protoName` unCamelCase lazy (#606) https://dart.googlesource.com/protobuf.git/+/ded1ac7 Document map key and value fields (#603) https://dart.googlesource.com/protobuf.git/+/8792f2a Remove redundant check in PbMap equality check (#604) https://dart.googlesource.com/protobuf.git/+/b7f9569 Tweak BuilderInfo and FieldInfo docs: (#597) https://dart.googlesource.com/protobuf.git/+/6f85c32 Remove a redundant cast (#598) https://dart.googlesource.com/protobuf.git/+/3df8669 Latest mono_repo (#601) https://dart.googlesource.com/protobuf.git/+/9da84ae Fix a potential issue in CodedBufferWriter (#594) https://dart.googlesource.com/protobuf.git/+/6be405f Remove old and unused test file (#589) https://dart.googlesource.com/protobuf.git/+/900cef5 Fix protoc_plugin run-tests make rule (#586) https://dart.googlesource.com/protobuf.git/+/2546269 Fix rounding when handling negative timestamps (#580) https://dart.googlesource.com/protobuf.git/+/8afce8d Fix Readme `pub get` instead of `pub install`. (#486) https://dart.googlesource.com/protobuf.git/+/782fd24 Avoid runtime function type check in lazily created singleton creator functions (#574) https://dart.googlesource.com/protobuf.git/+/a7e75cb Update README.md https://dart.googlesource.com/protobuf.git/+/23136dc Version bump (#563) https://dart.googlesource.com/protobuf.git/+/18346f5 Convert null keys and values to default when parsing map entries (#536) https://dart.googlesource.com/protobuf.git/+/bb4cf0b Bump to latest mono_repo - use latest actions (#561) https://dart.googlesource.com/protobuf.git/+/835ab75 Remove unneeded imports https://dart.googlesource.com/protobuf.git/+/ef733ac latest mono_repo https://dart.googlesource.com/protobuf.git/+/ecfb862 Fix test for latest analysis (#543) https://dart.googlesource.com/protobuf.git/+/26a0a26 fix insecure link in protoc_plugin readme https://dart.googlesource.com/protobuf.git/+/444e855 Bump dart-lang/setup-dart from 1.1 to 1.2 (#535) https://dart.googlesource.com/protobuf.git/+/d3e0e4a Fix analysis options https://dart.googlesource.com/protobuf.git/+/cf29280 Fix comment references ``` Diff: https://dart.googlesource.com/protobuf.git/+/c1eb6cb51af39ccbaa1a8e19349546586a5c8e31~..b149f801cf7a5e959cf1dbf72d61068ac275f24b/ Tested: relying on existing SDK and protobuf tests Change-Id: I7f89b998a0aba13999d180ee9814a26a5f1d054d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245228 Reviewed-by: Alexander Markov <alexmarkov@google.com> Reviewed-by: Ömer Ağacan <omersa@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
Apr 24, 2023
…n, sse, stream_channel, test, tools, usage, webdev Revisions updated by `dart tools/rev_sdk_deps.dart`. async (https://github.com/dart-lang/async/compare/0127813..ce650b0): ce650b0 2023-04-19 Nate Bosch Regression test for error rejecting transaction (#230) characters (https://github.com/dart-lang/characters/compare/ba8d557..b306414): b306414 2023-04-19 Lasse R.H. Nielsen Add tools to update and generate tables and tests. (#72) convert (https://github.com/dart-lang/convert/compare/8812e40..855aeac): 855aeac 2023-04-10 Kevin Moore Require Dart 2.19, fix override param name, update lints (#81) crypto (https://github.com/dart-lang/crypto/compare/1cb1528..77491f5): 77491f5 2023-04-19 Lasse R.H. Nielsen Make `DigestSink` implement `Sink` (#146) dartdoc (https://github.com/dart-lang/dartdoc/compare/a0755f5..8e8b36e): 8e8b36e3 2023-04-19 Janice Collins Fix up documentation on comment reference parser to align with wiki (#2851) b9178fce 2023-04-19 dependabot[bot] Bump github/codeql-action from 2.2.11 to 2.2.12 (#3390) 37b981c4 2023-04-19 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.2 (#3389) dadef24a 2023-04-10 dependabot[bot] Bump github/codeql-action from 2.2.9 to 2.2.11 (#3386) dda699a7 2023-04-10 Sam Rawlins Prepare mixin-like classes for Dart 3.0.0 (#3385) intl (https://github.com/dart-lang/intl/compare/a958db0..5d65e38): 5d65e38 2023-04-19 Moritz Update README.md 9972a89 2023-04-19 Moritz Update README.md 5c14faa 2023-04-18 Copybara-Service Merge pull request #584 from dart-lang:fixDateFormattingUrl 4ea644e 2023-04-17 Moritz Merge branch 'master' into fixDateFormattingUrl b0d5687 2023-04-17 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#574) 92149be 2023-04-17 Moritz Merge branch 'master' into fixDateFormattingUrl 5203d6e 2023-04-17 Googler Internal change bab667f 2023-04-17 Moritz Typo b0896b1 2023-04-17 Moritz Fix bug 43507e1 2023-04-14 Googler Internal change d8844a0 2023-04-14 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.2 (#579) 99ed16f 2023-04-13 Copybara-Service Merge pull request #572 from dart-lang:adaptBrowserTest 34e824c 2023-03-30 Moritz Adapt test to browser CLDR update markdown (https://github.com/dart-lang/markdown/compare/d437c85..5f98aea): 5f98aea 2023-04-20 Jonas Finnemann Jensen Throw, if `BlockSyntax.parseLines` loops indefinitely (#533) 86ebc2c 2023-04-19 Zhiguang Chen Fix `linkReferenceDefinitionPattern` (#532) sse (https://github.com/dart-lang/sse/compare/11e83a0..f947c3d): f947c3d 2023-04-10 Kevin Moore Require Dart 2.19, bump lints (#82) stream_channel (https://github.com/dart-lang/stream_channel/compare/74646ea..71d4690): 71d4690 2023-04-11 Tobe Osakwe Add example/example.dart (#52) test (https://github.com/dart-lang/test/compare/7832931..7fab079): 7fab0792 2023-04-19 Oleh Prypin Dart 3 compatibility: change `extends Iterator` to `implements Iterator` (#1997) 8f7682a5 2023-04-18 Nate Bosch Remove deprecation of test_api top level libraries (#1994) 7151486c 2023-04-14 Simon Binder Add support for Microsoft Edge (#1992) c1d686aa 2023-04-12 Parker Lougheed Fix "Improvements" link in `package:checks` migration guide (#1991) tools (https://github.com/dart-lang/tools/compare/545d7e1..5c9f45c): 5c9f45c 2023-04-20 Elias Yishak Move `dateStamp` getter to `utils.dart` (#83) usage (https://github.com/dart-lang/usage/compare/0698711..f97752f): f97752f 2023-04-10 Devon Carew update readme for deprecation (#192) webdev (https://github.com/dart-lang/webdev/compare/7546291..8b42c95): 8b42c950 2023-04-21 Anna Gringauze Cleanup record types display (#2070) 1cfb3bd6 2023-04-20 Elliott Brooks Update CONTRIBUTING docs (#2097) 941eda5b 2023-04-19 Elliott Brooks Add a test to make sure proper release procedure is followed for `dwds` and `webdev` (#2095) 2eb7c3ee 2023-04-17 Elliott Brooks Add Github workflow for Dart Code Metrics (#2092) 79a9bc9b 2023-04-17 Elliott Brooks Fix DCM analyzer warnings (#2094) 2a625039 2023-04-14 Elliott Brooks Add `vm_service` git package dependency override (#2078) 1fa19603 2023-04-12 Elliott Brooks Add CI check to remind contributor to update CHANGELOG (#2090) c7bb19e1 2023-04-12 Elliott Brooks Prevent PRs labeled `do-not-submit` from being merged (#2088) 3781ef9b 2023-04-10 Elliott Brooks Run mono_repo generate with version 6.5.3 (#2084) 843890c6 2023-04-10 Anna Gringauze Refactor record shape processing out of calculating record bound fields (#2074) Change-Id: I4ce65f9f79d5086c33c575e57eff300216392510 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/297800 Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Moritz Sümmermann <mosum@google.com> Commit-Queue: Moritz Sümmermann <mosum@google.com>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue was originally filed by rodion...@unipro.ru
Grammar mentions variables as possible interface members, but what purpose does it serve? Such members cannot be used in any way.
Subchapter on inheritance and overriding doe not mention static final fields being an exception, but they don't seem to be inherited:
interface S {
static final int foo = 1;
}
interface I extends S {}
main() {
Expect.equals(S.foo, I.foo);
}
Will add more issues in comments as they come up.
The text was updated successfully, but these errors were encountered: