Missing compile time errors for native syntax #54153
Labels
area-front-end
Use area-front-end for front end / CFE / kernel format related issues.
cfe-unreported-error
Issues for missing compile-time errors in CFE.
Comments
mraleph
added
the
area-front-end
johnniwinther
added
the
cfe-unreported-error
|
The test also runs on vm and compiles with dart2js with no errors, indicating that the responsibility of detecting the use of "native" in non-sdk libraries should be on CFE. (Analyzer correctly reports them). I have made a CL converting this multitest to a static error test, so it doesn't run on vm and web runtimes. I am adding error expectations for CFE, so that it continues to fail on CFE with missing compile-time errors. |
copybara-service bot
pushed a commit
that referenced
this issue
Apr 23, 2024
Multitests of compile-time errors should be converted to static error tests, so they don't run on runtime configurations. Static error tests also test for all the static errors, their positions, and error message, in a single test run. This test is currently failing on the common front end, and on all runtimes, and passing on the analyzer. The change keeps the failure on common front end by adding expectations for an error to be reported at the right places. Bug: #54153 Change-Id: Ic64961f6e0e575ec60626d4f70a0fdc5d71d024e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/363085 Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: William Hesse <whesse@google.com> Reviewed-by: Bob Nystrom <rnystrom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tests from language/syntax/syntax_native_test are failing on CFE due to missing compile time errors.
Maybe we should delete the test if we don't care?
/cc @johnniwinther
The text was updated successfully, but these errors were encountered: