[dart fix] inEnum does not apply transform

[Piinks]

I want to rename a deprecated enum value in flutter/flutter#139257

For example:

enum WidgetInspectorServiceExtensions {
  @Deprecated(use add instead)
  setPubRootDirectories,
  addPubRootDirectories,
  // ...
}

I wrote the following rule to try to rename uses of the deprecated enum:

  - title: "Use WidgetServiceExtensions.addPubRootDirectories"
    date: 2023-11-29
    element:
      uris: ['widgets.dart', 'material.dart', 'cupertino.dart']
      enum: 'setPubRootDirectories' # also tried constant?
      inEnum: 'WidgetInspectorServiceExtensions'
    changes:
    - kind: 'rename'
      newName: 'addPubRootDirectories'

The transformation I expected in the test was:

// Before
WidgetInspectorServiceExtensions.setPubRootDirectories;

// After
WidgetInspectorServiceExtensions.addPubRootDirectories;

But nothing happened.
This is the first inEnum fix for the framework, so there could be a bug?
The docs mention enum or constant for the element when using inEnum, neither of those worked. I tried field as well for good measure.

[keertip]

As this is the first rename for an enum value, it could be bug, that is does not work. Will take a look.

[bwilkerson]

It sounds like it's either a bug or a missing bit of functionality.

It should definitely be constant, based on the docs, though if it isn't working we could just change it to field given that enum's can now have other fields, and it would be less syntax to document, implement, and remember. Using enum would mean the whole enum (WidgetInspectorServiceExtensions in your example).

[keertip]

@Piinks , if i use constant to specify the enum value, the transform works, at least as a test - https://dart-review.googlesource.com/c/sdk/+/341389. Yet to try running dart fix, will check that out.

[Piinks]

Ah fabulous! I just tried that at tip of tree and it worked! Thanks @keertip!