Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qualified parameter name gives NPE in frog #831

Closed
DartBot opened this issue Dec 13, 2011 · 2 comments
Closed

qualified parameter name gives NPE in frog #831

DartBot opened this issue Dec 13, 2011 · 2 comments
Assignees

Comments

@DartBot
Copy link

DartBot commented Dec 13, 2011

This issue was originally filed by mattsh@google.com


I'm getting an NPE in frog with this program:

void main() {
  foo(34);
}
void foo(a.b) {
}

Note this is incorrect code because it is erroneously attempting to use 'a.b' as the parameter name. (This is actually fairly easy to do if you intend a.b to be the parameter type and you forget to include the parameter name.)

NullPointerException
    (TypeError: Cannot read property 'name' of null)
    at Parameter.<anonymous> (/usr/local/google/home/mattsh/dart-code1/dart/frog/minfrog:4552:35)
    at MethodMember.<anonymous> (/usr/local/google/home/mattsh/dart-code1/dart/frog/minfrog:5941:11)
    at DefinedType.<anonymous> (/usr/local/google/home/mattsh/dart-code1/dart/frog/minfrog:11562:7)
    at Library.<anonymous> (/usr/local/google/home/mattsh/dart-code1/dart/frog/minfrog:4321:10)
    at World.resolveAll (/usr/local/google/home/mattsh/dart-code1/dart/frog/minfrog:12630:9)
    at native
    at World.withTiming (/usr/local/google/home/mattsh/dart-code1/dart/frog/minfrog:12740:16)
    at World.runCompilationPhases (/usr/local/google/home/mattsh/dart-code1/dart/frog/minfrog:12566:8)
    at World.compile (/usr/local/google/home/mattsh/dart-code1/dart/frog/minfrog:12532:30)
    at compile (/usr/local/google/home/mattsh/dart-code1/dart/frog/minfrog:13184:32)

@dgrove
Copy link
Contributor

dgrove commented Dec 17, 2011

Set owner to @dgrove.
Added Started label.

@dgrove
Copy link
Contributor

dgrove commented Dec 20, 2011

Fixed in r2603


Added Fixed label.

copybara-service bot pushed a commit that referenced this issue May 17, 2023
…est_process, tools, webdev

Revisions updated by `dart tools/rev_sdk_deps.dart`.

convert (https://github.com/dart-lang/convert/compare/b652c00..9a387f0):
  9a387f0  2023-05-16  Devon Carew  blast_repo fixes (#83)

dartdoc (https://github.com/dart-lang/dartdoc/compare/2952f6b..702f3ff):
  702f3ff7  2023-05-16  Devon Carew  Update dependabot.yaml (#3415)

http (https://github.com/dart-lang/http/compare/981b63b..fb3b4be):
  fb3b4be  2023-05-16  Brian Quinlan  Revert "Support the NSURLSession WebSocket API (#921)" (#931)

mockito (https://github.com/dart-lang/mockito/compare/51a7728..3fadd2d):
  3fadd2d  2023-05-17  Ilya Yanok  Let users provide dummy values for types
  b14d571  2023-05-15  Googler  Fix for InvalidType

native (https://github.com/dart-lang/native/compare/e01aa63..3d89166):
  3d89166  2023-05-16  Daco Harkes  Add iOS x64 back (#41)

protobuf (https://github.com/dart-lang/protobuf/compare/05058a7..038872b):
  038872b  2023-05-16  Oleh Prypin  Remove implementation of `hashCode` because it makes enum values non-const in Dart 3 (#831)

test (https://github.com/dart-lang/test/compare/8e444df..cdedf40):
  cdedf40c  2023-05-16  Nate Bosch  Prepare to publish (#2016)

test_process (https://github.com/dart-lang/test_process/compare/b6a6cd5..d7a1711):
  d7a1711  2023-05-16  Nate Bosch  Prepare to publish (#44)

tools (https://github.com/dart-lang/tools/compare/62c9604..49da4ca):
  49da4ca  2023-05-12  Polina Cherkasova  Add memory events. (#92)

webdev (https://github.com/dart-lang/webdev/compare/60616ba..2b2ae0e):
  2b2ae0e8  2023-05-15  Elliott Brooks  Try to fix dependabot PRs (#2112)
  d19dafe0  2023-05-15  Elliott Brooks  Manual update deps (#2113)
  c0eb1069  2023-05-15  Elliott Brooks  Disable tests using webdriver (#2115)
  a16bc9f2  2023-05-15  Elliott Brooks  Dart Debug Extension builder fix (#2117)

Change-Id: Icd714c5d54cd3aee999e4ae3cc3a97928dc1a821
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/304120
Commit-Queue: Devon Carew <devoncarew@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants