Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugger.canSetScriptSource being reported incorrectly #2117

Closed
devoncarew opened this issue Mar 12, 2012 · 3 comments
Closed

Debugger.canSetScriptSource being reported incorrectly #2117

devoncarew opened this issue Mar 12, 2012 · 3 comments
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue

Comments

@devoncarew
Copy link
Member

The webkit call Debugger.canSetScriptSource is returning the value true, but the call Debugger.setScriptSource doesn't seem to do anything. I'm guessing that Debugger.setScriptSource isn't implemented yet; Debugger.canSetScriptSource should be changed to return false until the setScriptSource functionality is available.
@DartBot
Copy link

DartBot commented Mar 12, 2012

This comment was originally written by antonm@google.com

Set owner to podivilov@google.com.

@DartBot
Copy link

DartBot commented Apr 4, 2012

This comment was originally written by podivilov@google.com

Unfortunately there is currently no way to change Debugger.canSetScriptSource behavior. I suppose that Debugger.setScriptSource wouldn't be implemented any time soon for Dart, so please ignore the result of Debugger.canSetScriptSource.

@devoncarew
Copy link
Member Author

Sounds good, it's easy enough for us to ignore.

Added WontFix label.

@kevmoo kevmoo added closed-not-planned Closed as we don't intend to take action on the reported issue and removed resolution-wont_fix labels Mar 1, 2016
copybara-service bot pushed a commit that referenced this issue May 17, 2023
@devoncarew
[deps] rev convert, dartdoc, http, mockito, native, protobuf, test, t…
45aba19 
…est_process, tools, webdev

Revisions updated by `dart tools/rev_sdk_deps.dart`.

convert (https://github.com/dart-lang/convert/compare/b652c00..9a387f0):
  9a387f0  2023-05-16  Devon Carew  blast_repo fixes (#83)

dartdoc (https://github.com/dart-lang/dartdoc/compare/2952f6b..702f3ff):
  702f3ff7  2023-05-16  Devon Carew  Update dependabot.yaml (#3415)

http (https://github.com/dart-lang/http/compare/981b63b..fb3b4be):
  fb3b4be  2023-05-16  Brian Quinlan  Revert "Support the NSURLSession WebSocket API (#921)" (#931)

mockito (https://github.com/dart-lang/mockito/compare/51a7728..3fadd2d):
  3fadd2d  2023-05-17  Ilya Yanok  Let users provide dummy values for types
  b14d571  2023-05-15  Googler  Fix for InvalidType

native (https://github.com/dart-lang/native/compare/e01aa63..3d89166):
  3d89166  2023-05-16  Daco Harkes  Add iOS x64 back (#41)

protobuf (https://github.com/dart-lang/protobuf/compare/05058a7..038872b):
  038872b  2023-05-16  Oleh Prypin  Remove implementation of `hashCode` because it makes enum values non-const in Dart 3 (#831)

test (https://github.com/dart-lang/test/compare/8e444df..cdedf40):
  cdedf40c  2023-05-16  Nate Bosch  Prepare to publish (#2016)

test_process (https://github.com/dart-lang/test_process/compare/b6a6cd5..d7a1711):
  d7a1711  2023-05-16  Nate Bosch  Prepare to publish (#44)

tools (https://github.com/dart-lang/tools/compare/62c9604..49da4ca):
  49da4ca  2023-05-12  Polina Cherkasova  Add memory events. (#92)

webdev (https://github.com/dart-lang/webdev/compare/60616ba..2b2ae0e):
  2b2ae0e8  2023-05-15  Elliott Brooks  Try to fix dependabot PRs (#2112)
  d19dafe0  2023-05-15  Elliott Brooks  Manual update deps (#2113)
  c0eb1069  2023-05-15  Elliott Brooks  Disable tests using webdriver (#2115)
  a16bc9f2  2023-05-15  Elliott Brooks  Dart Debug Extension builder fix (#2117)

Change-Id: Icd714c5d54cd3aee999e4ae3cc3a97928dc1a821
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/304120
Commit-Queue: Devon Carew <devoncarew@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
copybara-service bot pushed a commit that referenced this issue Oct 17, 2023
@devoncarew
[deps] rev file, http, native, sse, test, tools, webdev
78debcc 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

file (https://github.com/google/file.dart/compare/a18ad1c..7418131):
  7418131  2023-10-11  Parker Lougheed  Remove now unnecessary glob dependency override (#226)

http (https://github.com/dart-lang/http/compare/88ec75e..7240d0a):
  7240d0a  2023-10-11  Brian Quinlan  Remove obsolete pigeon-generated file (#1032)
  827f4fe  2023-10-10  Brian Quinlan  Prepare to release cronet 0.4.0 (#1031)

native (https://github.com/dart-lang/native/compare/22f4481..757f503):
  757f503  2023-10-16  Gabriel Terwesten  Use `Logger.detached` for test loggers (#158)

sse (https://github.com/dart-lang/sse/compare/e190744..37df57d):
  37df57d  2023-10-13  Kevin Moore  Enable and fix latest lints (#91)

test (https://github.com/dart-lang/test/compare/4341470..ba050ae):
  ba050ae2  2023-10-13  Nate Bosch  Move functions to non-deprecated library (#2120)
  96e1ed2d  2023-10-13  Nate Bosch  Remove unused href field from error report (#2118)
  ae7f30e9  2023-10-13  Nate Bosch  Make compiler optional in calls to currentPlatform (#2117)

tools (https://github.com/dart-lang/tools/compare/92c5c15..ddeccf6):
  ddeccf6  2023-10-10  Elias Yishak  Handling malformed log items in log file (#175)

webdev (https://github.com/dart-lang/webdev/compare/7c2c2d7..8d48d5e):
  8d48d5ea  2023-10-13  Ben Konyi  Bump package:vm_service to ^12.0.0 (#2248)
  9102b427  2023-10-13  Anna Gringauze  Add evaluation test to webdev to catch issues with runtime debugging API (#2250)
  63c7e728  2023-10-12  Elliott Brooks  Cider expects messages from a Chrome extension to be a JS object, not a string (#2249)
  a10bf10e  2023-10-11  Devon Carew  regenerate from the latest package:mono_repo (#2247)

Change-Id: I5c16c1387b613d1e6076579b26e6b64735097b7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/330662
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kevmoo @devoncarew @DartBot