-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebRTC, Firefox nightly and Object.defineProperty #8361
Comments
Tentatively assigning to dart2js. cc @rakudrama. |
Added this to the M3 milestone. |
This comment was originally written by sami.y...@gmail.com This gist makes firefox nightly throw the error. At the moment, if you want to test this on firefox nightly, you have to browse to about:config, search for the media.peerconnection.enabled and set it to true. |
This looks like an HTML lib issue. I'll investigate. Removed Area-Dart2JS label. |
The initial issue is for ff, the constructors are called "mozRTCSessionDescription" and "mozRTCIceCandidate" whereas in chrome they are unprefixed. This will work just fine with Chrome. I added these prefixes, but then ran into another XPC exception when trying to use the constructed object, so this needs further investigation. |
This comment was originally written by sami.ylo...@gmail.com Has there been any progress with this? |
cc @efortuna. |
This comment was originally written by sami.ylo...@gmail.com As suggested here https://groups.google.com/a/dartlang.org/forum/?fromgroups#!topic/html-dev/9Z8FvfjCfbo I'll try this again =) Has there been any progress with this bug? |
See post with background: http://www.ylonen.eu/blog/2013/05/not-mega-but-giga/ |
I'm looking at it again today. |
Two fixes coming down the pipeline. The first one: https://codereview.chromium.org/16023011/ will be checked in shortly. This will allow you to correctly construct a number of the RTC firefox elements. The second one we are waiting to be pushed from Firefox nightly to their stable release. Basically RTCPeerConnection does not implement EventTarget and have an "addEventListener" as it should, but this fix should arrive in Firefox stable in a few weeks (it's fixed in Firefox nightly). |
Thanks for the update! |
This comment was originally written by sami.ylone...@gmail.com Thanks Emily. Tried this on nightly 24 but got another error now:
|
Pull down the latest build (23313) and try again. It should work now. |
This comment was originally written by sami.ylone...@gmail.com Getting there. RTCDataChannel is still not working though =) |
This issue was originally filed by sami.ylon...@gmail.com
Attemped to run some webrtc code compiled to js in latest firefox nightly and aurora.
What seems to happend is that assigning a callback to the onIceCandidate event throws with NS_ERROR_XPC_BAD_OP_ON_WN_PROTO: Illegal operation on WrappedNative prototype object.
After some tracing it seems that the dart2js generated code attempts to insert property get$onIceCandidate in the RTCPeerConnection object which looks like "[xpconnect wrapped nsIDOMRTCPeerConnection]".
the code that attempts to create the property looks like this: Object.defineProperty(obj, property, {value: value, enumerable: false, writable: true, configurable: true});
https://developer.mozilla.org/en-US/docs/JavaScript-DOM_Prototypes_in_Mozilla seems to claim that native dom objects dont have properties but the properties come from the obj.proto..
I aint clever enough to figure if this is the case =)
What version of the product are you using? On what operating system?
Dart Editor version 0.3.4_r18115
Dart SDK version 0.3.4.0_r18115
The text was updated successfully, but these errors were encountered: