Fix documentation of Uint32List and Uint64List #30626
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The currently documented maximum value is 2^n, but since 0 should be counted too actual value is only 2^n - 1.
|
LGTM |
|
@lrhn – can you shepard through Gerrit? |
whesse
pushed a commit
that referenced
this pull request
Sep 29, 2017
The currently documented maximum value is 2^n, but since 0 should be counted too actual value is only 2^n - 1. Pull request #30626 by https://github.com/renggli Change-Id: I85f920929f4cc524b7096f550e4dfdc628306399 Reviewed-on: https://dart-review.googlesource.com/9500 Reviewed-by: Lasse R.H. Nielsen <lrn@google.com> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
|
This was landed through a different CL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The currently documented max value is 2^n, but since 0 should be counted too the actual max value is only 2^n - 1.